Credit Memo with Zero Total: Order Status "Complete" and not "Closed"

[engcom-Echo]

Description (*)

Fixed Issues (if relevant)

1. Fixes Credit Memo with Zero Total: Order Status "Complete" and not "Closed" #22762

Manual testing scenarios (*)

See: Fixes #22762

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Echo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[engcom-Echo]

@magento run all tests

[engcom-Echo]

@magento run all tests

[rogyar]

The failing tests are not related to the current change. The same tests are being failed for other recent PRs

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7798 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Create order with zero Amount (all Grand Total, Total Paid, Total Refunded, Total Due, Subtotal, Shipping & Handling, Tax are zero ) in status = "Pending" and 1 SKU qty = 1;
2. Create Invoice and now Order is status = "Processing";
3. Ship Order -> now Order status is = "Complete";
4. Now create Credit memo and refund and return a product;

Before: ✖️ Order Status is "Complete"

After: ✔️ Order Status is "Closed"

[engcom-Kilo]

@magento run all tests

[simonmaass]

would be great if this makes it in 2.4

[slavvka]

@engcom-Echo Please fix the failing MFTF static checks that were recently introduced:

Test AdminCreateCreditMemoWithZeroPriceCheckOrderStatusTest is missing the required annotations: stories, severity

[slavvka]

@magento run Functional Tests CE

[engcom-Echo]

@magento run all tests

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7798 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

[m2-assistant]

Hi @engcom-Echo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.