-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[GraphQL] Compare products #29047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphQL] Compare products #29047
Conversation
Hi @Usik2203. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
Hi @rogyar |
Co-authored-by: Andrii Beziazychnyi <[email protected]>
- add test coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more description updates
Co-authored-by: Kevin Harper <[email protected]>
Co-authored-by: Kevin Harper <[email protected]>
@magento run all tests |
Hi @keharper |
@magento run all tests |
@magento run all tests |
@magento run all tests |
7a923b8
to
c53a3cf
Compare
@magento run all tests |
@magento run all tests |
@magento run all tests |
Hi @Usik2203, thank you for your contribution! |
Description (*)
Based on this schema compare-list.graphqls we should provide functionality for
list_id
parameter in schemaNew schema https://github.com/magento/architecture/pull/430/files
Purpose
list_id
is next:This PR adds
list_id
parameter during comparing products and add CompareListGraphQl moduleRelated Pull Requests
Fixed Issues (if relevant)
Manual testing scenario
Create Compare List
Getting compared list for Customer
Get compareList by ID
Add Products to compare list
Remove items from compare list
Assign compare list to customer
Delete compare list