Skip to content

Remove duplicated var customer.name from email template #29054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ptylek
Copy link
Contributor

@ptylek ptylek commented Jul 9, 2020

Description (*)

There are two customer.name variables (second is in line 13). One can be removed. I removed the first one as the same pattern appears in other email templates.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Cleanup, nothing will change.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Remove duplicated var customer.name from email template #29087: Remove duplicated var customer.name from email template

@ptylek ptylek added the Cleanup label Jul 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 9, 2020

Hi @ptylek. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@ptylek ptylek added the Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. label Jul 9, 2020
@ihor-sviziev ihor-sviziev self-assigned this Jul 9, 2020
@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 9, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests
But these changes should not cause any test failure

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7815 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

@magento create issue

@ghost ghost added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Jul 13, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Go to Admin-> Marketing -> Email Templates -> Add New Template;
  2. Load Reset Password template;
  3. Click on Insert Variable... button;

After:

Customer Name template variable is present in list

2020-07-13_12-57

@m2-assistant
Copy link

m2-assistant bot commented Jul 16, 2020

Hi @ptylek, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Customer Partner: creativestyle partners-contribution Pull Request is created by Magento Partner Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Issue] Remove duplicated var customer.name from email template
6 participants