fix Custom Admin Domain and Internal Redirects

[engcom-Charlie]

Description (*)

Fixed and covered by test

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Custom Admin Domain and Internal Redirects #28943

Manual testing scenarios (*)

1. see Custom Admin Domain and Internal Redirects #28943

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[engcom-Charlie]

@magento run all tests

[ihor-sviziev]

Good job! Approved! ✔

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7820 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Preconditions:

1. Custom admin domain set under Stores > Configuration > Advanced > Admin > Admin Base Url > Custom Admin Url

2. For local environment: Create additional virtualhost for url http://admin.magento24.loc and add admin.magento24.loc to hosts file

<VirtualHost *:80>
    ServerName          magento24.loc
    ServerAlias magento24.loc
    DocumentRoot        /var/www/html/magento24
<Directory /var/www/html/magento2dev/>
                Options Indexes FollowSymLinks MultiViews
                AllowOverride All
                Order allow,deny
                allow from all
Require all granted
</Directory>
 </VirtualHost>


<VirtualHost *:80>
    ServerName          admin.magento24.loc
    DocumentRoot        /var/www/html/magento24
<Directory /var/www/html/magento24/>
                Options Indexes FollowSymLinks MultiViews
                AllowOverride All
                Order allow,deny
                allow from all
Require all granted
</Directory>
 </VirtualHost>

Steps to reproduce (*)

1. Log in to an account with access to URL Rewrites
2. Navigate to Marketing > URL Rewrites
3. Click Add Url Rewrite
4. Enter 123456789 as the request path and 987654321 as the target path, then hit save.
5. Click Add Url Rewrite again
6. Enter 123456789 as the request path and xzc as the target path, then hit save.

Before: ✖️ You're redirected to the homepage of the default store.

After: ✔️ Was redirected back to the URL Rewrite Edit page with an error message Request Path for Specified Store already exists.

[m2-assistant]

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.