Skip to content

[MFTF] use AdminNavigateNewCustomerActionGroup to go to new customer page #29134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 29, 2020
Merged

[MFTF] use AdminNavigateNewCustomerActionGroup to go to new customer page #29134

merged 4 commits into from
Jul 29, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Jul 14, 2020 •
edited by m2-assistant bot
Loading

This PR use AdminNavigateNewCustomerActionGroup to go to AdminNewCustomerPage.url

Resolved issues:

  1. resolves [Issue] [MFTF] use AdminNavigateNewCustomerActionGroup to go to new customer page #29287: [MFTF] use AdminNavigateNewCustomerActionGroup to go to new customer page

@m2-assistant
Copy link

m2-assistant bot commented Jul 14, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Customer Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 14, 2020
@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@Usik2203
Copy link
Contributor Author

@magento run Functional Tests B2B

@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests B2B

@Usik2203 Usik2203 force-pushed the AdminNavigateNewCustomerActionGroup branch from 4723587 to 07003f7 Compare July 15, 2020 07:53
@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@eduard13 eduard13 self-assigned this Jul 22, 2020
@eduard13
Copy link
Contributor

@magento run all tests

@eduard13 eduard13 added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 22, 2020
eduard13
eduard13 approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-7868 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jul 23, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Kilo engcom-Kilo self-assigned this Jul 23, 2020
@engcom-Kilo
Copy link
Contributor

@magento run all tests

@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 27, 2020
Closed
@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 27, 2020
@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Jul 27, 2020
magento-engcom-team pushed a commit that referenced this pull request Jul 29, 2020
@slavvka
ENGCOM-7868: [MFTF] use AdminNavigateNewCustomerActionGroup to go to …
e3d2290 
…new customer page #29134
@magento-engcom-team magento-engcom-team merged commit 844955e into magento:2.4-develop Jul 29, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 29, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduard13 eduard13 eduard13 approved these changes

Assignees

@eduard13 eduard13

@engcom-Alfa engcom-Alfa

@engcom-Kilo engcom-Kilo

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Customer Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] use AdminNavigateNewCustomerActionGroup to go to new customer page
5 participants
@Usik2203 @eduard13 @magento-engcom-team @engcom-Alfa @engcom-Kilo