[MFTF] Create new ActionGroup for saving product #29142

Usik2203 · 2020-07-15T08:52:00Z

This PR creates new AdminProductFormSaveActionGroup for saving product form

Resolved issues:

resolves [Issue] [MFTF] Create new ActionGroup for saving product #29292: [MFTF] Create new ActionGroup for saving product

m2-assistant · 2020-07-15T08:52:02Z

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Usik2203 · 2020-07-15T08:52:23Z

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

Usik2203 · 2020-07-16T08:28:06Z

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

eduard13

Thank you for your contribution 👍

magento-engcom-team · 2020-07-20T06:09:42Z

Hi @eduard13, thank you for the review.
ENGCOM-7857 has been created to process this Pull Request
✳️ @eduard13, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

eduard13 · 2020-07-20T06:11:17Z

@magento run all tests

engcom-Alfa · 2020-07-20T07:45:14Z

QA not applicable

engcom-Alfa · 2020-07-27T10:03:54Z

@magento create issue

slavvka

@Usik2203 @engcom-Alfa @engcom-Echo After 2.4.0 release this PR got conflicts. Please resolve them

Pull Request state was updated. Re-review required.

Usik2203 · 2020-07-28T17:51:49Z

@magento run all tests

Usik2203 · 2020-07-29T09:01:29Z

@magento run all tests

Usik2203 · 2020-07-29T15:11:55Z

@magento run Functional Tests CE , Functional Tests B2B

Usik2203 · 2020-07-30T10:10:50Z

@magento run all tests

Usik2203 · 2020-07-30T15:07:29Z

@magento run WebAPI Tests , Static Tests , Integration Tests , Functional Tests B2B

engcom-Echo · 2020-07-31T06:11:22Z

Failed functional and Integration tests not related to the changes in this PR

eduard13

Indeed, the failed ones aren't related with this PR

magento-engcom-team · 2020-07-31T06:16:40Z

Hi @eduard13, thank you for the review.
ENGCOM-7857 has been created to process this Pull Request

engcom-Alfa · 2020-07-31T10:41:04Z

QA not applicable

m2-assistant · 2020-08-01T21:07:25Z

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Create action group for saving product

1b40d89

ghost added the Progress: pending review label Jul 15, 2020

magento-engcom-team added Component: Bundle Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 15, 2020

Merge branch '2.4-develop' into mftf-click-save-product

bbed38e

eduard13 self-assigned this Jul 17, 2020

eduard13 previously approved these changes Jul 20, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: pending review labels Jul 20, 2020

eduard13 added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 20, 2020

engcom-Alfa self-assigned this Jul 20, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jul 20, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Jul 20, 2020

engcom-Echo self-assigned this Jul 20, 2020

engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 20, 2020

m2-assistant bot mentioned this pull request Jul 27, 2020

[Issue] [MFTF] Create new ActionGroup for saving product #29292

Closed

ghost added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P3 May be fixed according to the position in the backlog. labels Jul 27, 2020

ghost added the Progress: accept label Jul 27, 2020

slavvka requested changes Jul 28, 2020

View reviewed changes

ghost assigned slavvka Jul 28, 2020

ghost added Progress: needs update and removed Progress: accept labels Jul 28, 2020

Merge branch '2.4-develop' into mftf-click-save-product

2c8b12a

Merge branch '2.4-develop' into mftf-click-save-product

15e5fa4

Merge branch '2.4-develop' into mftf-click-save-product

6229778

engcom-Echo requested a review from eduard13 July 31, 2020 06:11

eduard13 approved these changes Jul 31, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Jul 31, 2020

ghost added Progress: testing in progress Progress: extended testing Progress: accept and removed Progress: ready for testing Progress: testing in progress Progress: extended testing labels Jul 31, 2020

magento-engcom-team pushed a commit that referenced this pull request Aug 1, 2020

ENGCOM-7857: [MFTF] Create new ActionGroup for saving product #29142

8ccb2c6

magento-engcom-team merged commit 69a59da into magento:2.4-develop Aug 1, 2020

[MFTF] Create new ActionGroup for saving product #29142

[MFTF] Create new ActionGroup for saving product #29142

Uh oh!

Conversation

Usik2203 commented Jul 15, 2020 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Resolved issues:

Uh oh!

m2-assistant bot commented Jul 15, 2020

Uh oh!

Usik2203 commented Jul 15, 2020

Uh oh!

Usik2203 commented Jul 16, 2020

Uh oh!

eduard13 left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Jul 20, 2020

Uh oh!

eduard13 commented Jul 20, 2020

Uh oh!

engcom-Alfa commented Jul 20, 2020

Uh oh!

engcom-Alfa commented Jul 27, 2020

Uh oh!

slavvka left a comment

Choose a reason for hiding this comment

Uh oh!

Usik2203 commented Jul 28, 2020

Uh oh!

Usik2203 commented Jul 29, 2020

Uh oh!

Usik2203 commented Jul 29, 2020

Uh oh!

Usik2203 commented Jul 30, 2020

Uh oh!

Usik2203 commented Jul 30, 2020

Uh oh!

engcom-Echo commented Jul 31, 2020

Uh oh!

eduard13 left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Jul 31, 2020

Uh oh!

engcom-Alfa commented Jul 31, 2020

Uh oh!

m2-assistant bot commented Aug 1, 2020

Uh oh!

Uh oh!

Usik2203 commented Jul 15, 2020 •

edited by m2-assistant bot

Loading