Generetae thumbnails only if image have bigger size then defined in configuration, to aviod stretched images #29149

Nazar65 · 2020-07-15T12:32:33Z

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

magento/adobe-stock-integration#1422 Small image is stretched all over the image thumbnail

Manual testing scenarios (*)

Go to Content - Media Gallery
Upload a small image to the Media Gallery
Observe the image thumbnail

The image is not stretched and displayed as it is

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

configuration, to aviod strechet images

m2-assistant · 2020-07-15T12:32:36Z

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Nazar65 · 2020-07-15T12:33:20Z

@magento run all tests

Nazar65 · 2020-07-15T16:43:02Z

@magento run alll tests

Nazar65 · 2020-07-15T17:08:27Z

@magento run all tests

Nazar65 · 2020-07-15T18:30:40Z

@magento run all tests

nuzil · 2020-07-16T06:23:50Z

app/code/Magento/Cms/Model/Wysiwyg/Images/Storage.php

+    /**
+     * Return width height for the image resizing.
+     *
+     * @param string $source


Can you please define return param?

but they already defined in strict types ? why need to duplicate it ?

Agree. Despite its a requirement, i prefer to define a return type also, so for example
@return string[] or int[]

nuzil · 2020-07-16T06:29:46Z

app/code/Magento/Cms/Model/Wysiwyg/Images/Storage.php

+        if ($imageWidth && $imageHeight) {
+            $imageWidth = $configWidth > $imageWidth ? $imageWidth : $configWidth;
+            $imageHeight = $configHeight > $imageHeight ? $imageHeight : $configHeight;
+        } else {


Honestly I'm not a fan of "else" statement where they can be avoided, what about

if ($imageWidth && $imageHeight) { $imageWidth = $configWidth > $imageWidth ? $imageWidth : $configWidth; $imageHeight = $configHeight > $imageHeight ? $imageHeight : $configHeight; return [$imageWidth, $imageHeight]; } return [$configWidth, $configHeight];

nuzil · 2020-07-16T06:34:46Z

app/code/Magento/Cms/Model/Wysiwyg/Images/Storage.php

+
+        list($imageWidth, $imageHeight) = $this->getResizedParams($source);
+
+        $image->resize($imageWidth, $imageHeight);


Can you maybe drop some info here, do we still need a resize even if image size stays the same?

yes, because we create a new image in thumbnail path, and other application expects image to be in thumbnails, and ignore thumbnail generation will be BIC changes.

Nazar65 · 2020-07-16T07:28:09Z

@magento run all tests

magento-engcom-team · 2020-07-16T11:59:33Z

Hi @nuzil, thank you for the review.
ENGCOM-7847 has been created to process this Pull Request

engcom-Bravo · 2020-07-17T07:55:19Z

✔️ QA Passed

Before the PR

After the PR

Test on Cucumber Studio - https://studio.cucumber.io/projects/131313/test-plan/folders/1337102/scenarios/4968534

… defined in configuration, to aviod stretched images #29149

m2-assistant · 2020-07-18T09:17:41Z

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Generetae thumbnails only if image have bigger size then defined in

eaaea72

configuration, to aviod strechet images

ghost added the Progress: pending review label Jul 15, 2020

magento-engcom-team added Component: Cms Release Line: 2.4 labels Jul 15, 2020

Nazar65 mentioned this pull request Jul 15, 2020

Small image is stretched all over the image thumbnail magento/adobe-stock-integration#1422

Closed

Nazar65 changed the title ~~Generetae thumbnails only if image have bigger size then defined in configuration, to aviod strechet images~~ Generetae thumbnails only if image have bigger size then defined in configuration, to aviod stretched images Jul 15, 2020

Nazar65 added 3 commits July 15, 2020 16:41

Cover changes with integration tests

97b6b50

Refactor to pass unit tests

049a575

Small improvements

fce4c28

Refactoring

2c9ba2e

nuzil requested changes Jul 16, 2020

View reviewed changes

ghost assigned nuzil Jul 16, 2020

ghost added Progress: needs update and removed Progress: pending review labels Jul 16, 2020

Code review suggestion

a890636

nuzil added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage labels Jul 16, 2020

nuzil approved these changes Jul 16, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Jul 16, 2020

engcom-Bravo self-assigned this Jul 17, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jul 17, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Jul 17, 2020

engcom-Echo self-assigned this Jul 17, 2020

engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Jul 17, 2020

ghost added Progress: accept and removed Progress: extended testing labels Jul 17, 2020

sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Jul 17, 2020

lenaorobei added this to the 2.4.1 milestone Jul 17, 2020

magento-engcom-team pushed a commit that referenced this pull request Jul 18, 2020

ENGCOM-7847: Generetae thumbnails only if image have bigger size then…

ee71354

… defined in configuration, to aviod stretched images #29149

magento-engcom-team merged commit 0424596 into magento:2.4-develop Jul 18, 2020


		list($imageWidth, $imageHeight) = $this->getResizedParams($source);

		$image->resize($imageWidth, $imageHeight);

Generetae thumbnails only if image have bigger size then defined in configuration, to aviod stretched images #29149

Generetae thumbnails only if image have bigger size then defined in configuration, to aviod stretched images #29149

Uh oh!

Conversation

Nazar65 commented Jul 15, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jul 15, 2020

Uh oh!

Nazar65 commented Jul 15, 2020

Uh oh!

Nazar65 commented Jul 15, 2020

Uh oh!

Nazar65 commented Jul 15, 2020

Uh oh!

Nazar65 commented Jul 15, 2020

Uh oh!

nuzil Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

Nazar65 Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

nuzil Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

nuzil Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

Nazar65 Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

nuzil Jul 16, 2020

Choose a reason for hiding this comment

Uh oh!

Nazar65 Jul 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nazar65 commented Jul 16, 2020

Uh oh!

magento-engcom-team commented Jul 16, 2020

Uh oh!

engcom-Bravo commented Jul 17, 2020

Uh oh!

m2-assistant bot commented Jul 18, 2020

Uh oh!

Uh oh!

Nazar65 Jul 16, 2020 •

edited

Loading