#28947 Fix scope reset on new synonym form

[srsathish92]

Description (*)

This PR to update correct default value "0:0" & data type for scope field in new synonym group form. that's why reset not working due to incorrect default value on new form.

Related Pull Requests

#29193 - I guess this js change not required because rest of the select resetting works fine in other forms (ex: customer form)

Fixed Issues (if relevant)

1. Fixes Scope not reset on New Synonym Group form #28947

Manual testing scenarios (*)

1. please check steps to reproduce on Scope not reset on New Synonym Group form #28947

Questions or comments

NA

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @srsathish92. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[srsathish92]

@magento run all test

[rogyar]

Hi @srsathish92. Good catch, thank you. Due to the definition of done all new changes should be covered by auto-tests. Could you write an MFTF test that goes through the "Steps to reproduce" and makes sure that the issue does not appear anymore?

Thank you!

[srsathish92]

@magento run all tests

[srsathish92]

@rogyar I have updated MFTF test case. Can you please review now?

[srsathish92]

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B,Sample Data Tests CE,Sample Data Tests EE,Sample Data Tests B2B

[rogyar]

Hi @srsathish92. Good job.
However, something went wrong with the functional tests. As you can see, all of them are failing with no report. Usually, it happens if the test generation step is broken somehow (a wrong reference, missing action group, etc). Please, try running the tests locally one more time.

[srsathish92]

@magento run all tests

[srsathish92]

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B, Integration Tests

[srsathish92]

@magento run Functional Tests B2B, Integration Tests

[rogyar]

The same failing integration test occurs for other PRs, so we may assume that it's not related. RMA functionality is not affected by the current changeset somehow, so the failing functional tests are not related either.

@srsathish92 great job!

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7917 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Go to Admin -> Marketing -> SEO & Search -> Search Synonyms;
2. Click on New Synonym Group button;
3. Select scope different than the default;
4. Enter other details;
5. Click on Reset button;

Before: ✖️ Not all items have been reset

After: ✔️ All items have been reset

[engcom-Echo]

@magento run all tests

[m2-assistant]

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.