Remove backup menu if the backup feature is disabled #29222

edenduong · 2020-07-21T13:07:27Z

Description (*)

This PR will remove the backup menu in backend if the backup feature is disabled in Configuration

Related Pull Requests

Fixed Issues (if relevant)

Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

Go to stores -> configurations, Advanced, system. DIsable backup

Clear cache
Check the backup menu:

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Remove backup menu if the backup feature is disabled #29280: Remove backup menu if the backup feature is disabled

m2-assistant · 2020-07-21T13:07:30Z

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

edenduong · 2020-07-22T09:28:59Z

@magento run all tests

lbajsarowicz

Why won't just use dependsOnConfig on <add instruction in magento/module-backup/etc/adminhtml/menu.xml:10 ?

<add id="Magento_Backup::system_tools_backup" title="Backups" translate="title" module="Magento_Backup" sortOrder="30" parent="Magento_Backend::system_tools" action="backup/index" resource="Magento_Backup::backup" dependsOnConfig="system/backup/functionality_enabled"/>

edenduong · 2020-07-25T13:44:40Z

@lbajsarowicz : Thank you very much ! I forgot that attribute :)

lbajsarowicz

Perfect!

lbajsarowicz · 2020-07-25T14:21:12Z

@edenduong That is why we have our community 👏

magento-engcom-team · 2020-07-25T14:22:43Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7883 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

edenduong · 2020-07-26T04:13:24Z

@magento run all tests

engcom-Alfa · 2020-07-27T05:46:54Z

@magento create issue

engcom-Alfa · 2020-07-27T06:18:19Z

✔️ QA Passed

Manual testing scenario:

Go to stores -> configurations, Advanced, system. DIsable backup

Clear cache
Check the backup menu:

Before: ✖️ The backup is still located in the menu

After: ✔️ Backup excluded from the menu

…disable

engcom-Charlie · 2020-07-28T09:48:40Z

@magento run all tests

engcom-Charlie · 2020-07-28T09:54:45Z

Hi @lbajsarowicz, please review test coverage.

lbajsarowicz

✔️ Perfect! Thank you.

magento-engcom-team · 2020-07-28T09:58:33Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7883 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Alfa · 2020-07-28T12:24:17Z

✔️ QA Passed

engcom-Charlie · 2020-07-30T08:57:11Z

@magento run all tests

m2-assistant · 2020-08-08T06:56:56Z

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

ghost added the Progress: pending review label Jul 21, 2020

magento-engcom-team added Component: Backup Component: Captcha Release Line: 2.4 tech-partners-contribution Technology Partner: Magestore labels Jul 21, 2020

edenduong force-pushed the 2.4-contribute/remove_backup_menu_if_disable branch from ac34c43 to 0bb6f5d Compare July 21, 2020 13:10

lbajsarowicz suggested changes Jul 25, 2020

View reviewed changes

ghost assigned lbajsarowicz Jul 25, 2020

ghost added Progress: needs update and removed Progress: pending review labels Jul 25, 2020

Remove backup menu if the backup feature is disabled

3907936

edenduong force-pushed the 2.4-contribute/remove_backup_menu_if_disable branch from 9778b1a to 3907936 Compare July 25, 2020 13:43

lbajsarowicz approved these changes Jul 25, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Jul 25, 2020

magento-engcom-team removed the Component: Captcha label Jul 25, 2020

engcom-Alfa self-assigned this Jul 27, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jul 27, 2020

m2-assistant bot mentioned this pull request Jul 27, 2020

[Issue] Remove backup menu if the backup feature is disabled #29280

Closed

4 tasks

ghost removed the Progress: testing in progress label Jul 27, 2020

engcom-Charlie and others added 2 commits July 28, 2020 12:42

Merge branch '2.4-develop' into 2.4-contribute/remove_backup_menu_if_…

dab9581

…disable

add mftf

c3d76f7

engcom-Charlie requested a review from lbajsarowicz July 28, 2020 09:51

ghost added Progress: review and removed Progress: extended testing labels Jul 28, 2020

lbajsarowicz approved these changes Jul 28, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: review labels Jul 28, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jul 28, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Jul 28, 2020

engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 29, 2020

add testCase id

50b62ea

ghost added Progress: accept and removed Progress: extended testing labels Aug 5, 2020

magento-engcom-team pushed a commit that referenced this pull request Aug 8, 2020

ENGCOM-7883: Remove backup menu if the backup feature is disabled #29222

1631bb5

magento-engcom-team merged commit ddfffa5 into magento:2.4-develop Aug 8, 2020

Remove backup menu if the backup feature is disabled #29222

Remove backup menu if the backup feature is disabled #29222

Uh oh!

Conversation

edenduong commented Jul 21, 2020 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Jul 21, 2020

Uh oh!

edenduong commented Jul 22, 2020

Uh oh!

lbajsarowicz left a comment

Choose a reason for hiding this comment

Uh oh!

edenduong commented Jul 25, 2020

Uh oh!

lbajsarowicz left a comment

Choose a reason for hiding this comment

Uh oh!

lbajsarowicz commented Jul 25, 2020

Uh oh!

magento-engcom-team commented Jul 25, 2020

Uh oh!

edenduong commented Jul 26, 2020

Uh oh!

engcom-Alfa commented Jul 27, 2020

Uh oh!

engcom-Alfa commented Jul 27, 2020

Uh oh!

engcom-Charlie commented Jul 28, 2020

Uh oh!

engcom-Charlie commented Jul 28, 2020

Uh oh!

lbajsarowicz left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Jul 28, 2020

Uh oh!

engcom-Alfa commented Jul 28, 2020

Uh oh!

engcom-Charlie commented Jul 30, 2020

Uh oh!

m2-assistant bot commented Aug 8, 2020

Uh oh!

Uh oh!

edenduong commented Jul 21, 2020 •

edited by m2-assistant bot

Loading