Skip to content

#1618: Duplicated items in Used in Entities filters #29290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2020
Merged

#1618: Duplicated items in Used in Entities filters #29290

merged 2 commits into from
Aug 1, 2020

Conversation

joweecaquicla
Copy link

Description (*)

Prevent simultaneous requests when user types search key in ui-select.

Related Pull Requests

N/A

Fixed Issues (if relevant)

  1. Fixes Duplicated items in Used in Entities filters  adobe-stock-integration#1618

Manual testing scenarios (*)

  1. Go to Content - Media Gallery
  2. Click Filters
  3. Expand, for example, Used in Pages filter
  4. Start typing page into Page Title field

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

magento/adobe-stock-integration#1618: Duplicated items in used in ent…
9c25127 
…ities filters - prevent simultaneous requests when user types search key
@m2-assistant
Copy link

m2-assistant bot commented Jul 27, 2020

Hi @joweecaquicla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@joweecaquicla
Copy link
Author

@magento run all tests

sivaschenko
sivaschenko requested changes Jul 27, 2020
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @joweecaquicla ! Please see my comments

app/code/Magento/Ui/view/base/web/js/form/element/ui-select.js Outdated
@@ -1167,7 +1167,7 @@ define([
return;
}

if (searchKey !== this.lastSearchKey) {
if (searchKey !== this.lastSearchKey || currentPage === 1) {
Copy link
Member

@sivaschenko sivaschenko Jul 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be honest I think we can even simplify this condition (considering how currentPage is calculated at the beginning of this method)

Suggested change
if (searchKey !== this.lastSearchKey || currentPage === 1) {
if (currentPage === 1) {

@ghost ghost assigned sivaschenko Jul 27, 2020
@sivaschenko sivaschenko added Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Jul 27, 2020
@joweecaquicla
Copy link
Author

@magento run all tests

@sivaschenko sivaschenko mentioned this pull request Jul 28, 2020
Merged
@sivaschenko
Copy link
Member

@chalov-anton please test together with magento/adobe-stock-integration#1655

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-7902 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@sivaschenko sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jul 28, 2020
@sivaschenko
Copy link
Member

ui-select functionality is covered by various MFTF tests

@engcom-Bravo engcom-Bravo self-assigned this Jul 29, 2020
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Tested together with Adobe Stock PR - magento/adobe-stock-integration#1655
The original issue is not reproducible.

Added a scenario to regression scope - https://studio.cucumber.io/projects/131313/test-plan/folders/1320712/scenarios/5021347

@engcom-Bravo engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Jul 29, 2020
@sivaschenko
Copy link
Member

@magento run Functional Tests CE,Integration Tests

@lenaorobei lenaorobei added this to the 2.4.1 milestone Jul 29, 2020
magento-engcom-team pushed a commit that referenced this pull request Aug 1, 2020
@slavvka
ENGCOM-7902: #1618: Duplicated items in Used in Entities filters #29290
0906f77
@magento-engcom-team magento-engcom-team merged commit 4da3b40 into magento:2.4-develop Aug 1, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 1, 2020

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

@engcom-Bravo engcom-Bravo

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Ui Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

Duplicated items in Used in Entities filters
5 participants
@joweecaquicla @sivaschenko @magento-engcom-team @engcom-Bravo @lenaorobei