Skip to content

[MFTF] Test scenario for "Apply shopping cart rule to a single bundle item" (#28921) #29348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2020

Conversation

zhartaunik
Copy link
Contributor

Test scenario for "Apply shopping cart rule to a single bundle item" (#28921)

Description (*)

Test scenario for the following bug:

  1. Create a bundle product with two option each contain two product in it
  2. Create one option as main as the title with two simple product (a&b) - (Dropdown)
  3. Create the second option as a sub as the title with two simple product(c&d)- (Checkbox)
  4. Create a shopping cart rule
  5. Select a "percent of product price discount"
  6. Add 10 % to the discount amount
  7. We should add the main option two product in the rule like( SKU is one of (a&b)
  8. Apply the rule
  9. Go to the frontend
  10. Select one SKU from the dropdown of the main simple product and checkbox one sub simple product
  11. Add to cart
  12. Go to cart page
  13. Check the discount is applied total of two product

Related Pull Requests

Fixed Issues (if relevant)

MFTF test for this bug

  1. Fixes Apply shopping cart rule to a single bundle item #28921

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • [*] Pull request has a meaningful description of its purpose
  • [*] All commits are accompanied by meaningful commit messages
  • [*] All new or changed code is covered with unit/integration tests (if applicable)
  • [*] All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 31, 2020

Hi @zhartaunik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@zhartaunik
Copy link
Contributor Author

@magento run Functional Tests CE

@zhartaunik
Copy link
Contributor Author

@magento run all tests

Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed that in other PR.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7933 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 4, 2020
@engcom-Alfa engcom-Alfa self-assigned this Aug 4, 2020
@sdzhepa sdzhepa added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 11, 2020
@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Aug 12, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@slavvka
Copy link
Member

slavvka commented Aug 13, 2020

@magento run all tests

Copy link
Member

@slavvka slavvka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zhartaunik @engcom-Alfa The functional test MC-16007: Add simple product to order from shopping cart test is failing constantly with your changes. Please fix it before we can merge it

@zhartaunik
Copy link
Contributor Author

zhartaunik commented Aug 14, 2020

Hi @slavvka
Could you please clarify how the only functional test (my code contains only one functional test) may break adding simple product to cart?
As I analyzed MC-16007 test results - it refers to insufficient indexation, as on screenshot there no created customer found on the grid in adminarea.
Do you need me to fix MC-16007 in this ticket?

@engcom-Charlie engcom-Charlie self-assigned this Aug 17, 2020
@engcom-Charlie
Copy link
Contributor

Hi @zhartaunik, please fix the falling test and we will be able to continue with your PR.

@zhartaunik
Copy link
Contributor Author

@magento run Functional Tests CE

@zhartaunik
Copy link
Contributor Author

@engcom-Charlie @slavvka
I ran again Functional Tests and they passed successfully. It was weird that my test affected somehow some other isolated test. Is it often case, when some functional test fails and then passes successfully?

@sidolov sidolov changed the title Test scenario for "Apply shopping cart rule to a single bundle item" (#28921) [MFTF] Test scenario for "Apply shopping cart rule to a single bundle item" (#28921) Aug 27, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 2, 2020

Hi @zhartaunik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@zhartaunik zhartaunik deleted the issue-28921 branch September 2, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: SalesRule Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Apply shopping cart rule to a single bundle item
8 participants