Skip to content

Fix #29194 Update tier price div visibility #29353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2020
Merged

Fix #29194 Update tier price div visibility #29353

merged 1 commit into from
Aug 26, 2020

Conversation

srsathish92
Copy link
Contributor

Description (*)

This PR to hide tier price div on configurable products when the drop down option (simple product) has no tier prices.

Fixed Issues (if relevant)

  1. Fixes CSS for tier prices block still visible when there are no tier prices #29194

Manual testing scenarios (*)

Please see the steps to reproduce on #29194

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 31, 2020

Hi @srsathish92. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@lbajsarowicz
Copy link
Contributor

@magento run all tests

@srsathish92
Copy link
Contributor Author

@magento run Functional Tests B2B

krzksz
krzksz suggested changes Aug 3, 2020
View reviewed changes
@ghost ghost assigned krzksz Aug 3, 2020
@srsathish92
Copy link
Contributor Author

@magento run all tests

@srsathish92 srsathish92 requested a review from krzksz August 3, 2020 13:02
@srsathish92
Copy link
Contributor Author

@magento run Functional Tests B2B, Unit Tests

krzksz
krzksz previously approved these changes Aug 4, 2020
View reviewed changes
@krzksz krzksz added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests and removed Progress: ready for testing labels Aug 4, 2020
@krzksz
Copy link
Contributor

krzksz commented Aug 4, 2020

Hey @srsathish92, thanks for contribution!

Would you be able to cover your change with automatic tests so we are sure this error doesn't pop up in the future?

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-7948 has been created to process this Pull Request

engcom-Alfa
engcom-Alfa requested changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @srsathish92 .
Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated test.
Thanks!

@ghost ghost assigned engcom-Alfa Aug 6, 2020
@ghost ghost dismissed krzksz’s stale review August 6, 2020 07:21

Pull Request state was updated. Re-review required.

@srsathish92
Copy link
Contributor Author

@engcom-Alfa @krzksz Sure, I will update test case

@srsathish92
Copy link
Contributor Author

@magento run all tests

@srsathish92
Copy link
Contributor Author

@magento run all tests

@engcom-Alfa
Copy link
Contributor

Hi @krzksz . Could you review the latest changes?
Thanks!

lbajsarowicz
lbajsarowicz approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ When it comes to MFTF tests - these are fine.

@ghost ghost assigned lbajsarowicz Aug 14, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7948 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Aug 17, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before: ✖️ The tier price block, including CSS stylings such as background or border, is visible even when there are no tier prices to display.

Peek 2020-07-23 15-51

After: ✔️ The tier price block, including associated CSS, disappeared from the frontend when choosing a simple product that doesn't have tier prices.

Peek 2020-08-17 13-17

@engcom-Kilo engcom-Kilo self-assigned this Aug 17, 2020
@engcom-Kilo engcom-Kilo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Aug 17, 2020
@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 17, 2020
@engcom-Hotel engcom-Hotel self-assigned this Aug 25, 2020
@engcom-Kilo engcom-Kilo removed their assignment Aug 25, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request Aug 26, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Aug 26, 2020
@sidolov
ENGCOM-7948: Fix #29194 Update tier price div visibility #29353
e7ce007
@magento-engcom-team magento-engcom-team merged commit f30cac4 into magento:2.4-develop Aug 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 26, 2020

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@engcom-Alfa engcom-Alfa Awaiting requested review from engcom-Alfa

@krzksz krzksz Awaiting requested review from krzksz

Assignees

@krzksz krzksz

@lbajsarowicz lbajsarowicz

@engcom-Alfa engcom-Alfa

@engcom-Hotel engcom-Hotel

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: ConfigurableProduct Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS for tier prices block still visible when there are no tier prices
8 participants
@srsathish92 @lbajsarowicz @krzksz @magento-engcom-team @engcom-Alfa @sidolov @engcom-Hotel @engcom-Kilo