Skip to content

#29354 :- Login as Customer storefront banner is not sticky #29415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 14, 2020
Merged

#29354 :- Login as Customer storefront banner is not sticky #29415

merged 12 commits into from
Sep 14, 2020

Conversation

konarshankar07
Copy link
Contributor

Description (*)

This PR will add the sticky login as customer banner

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Login as Customer storefront banner is not sticky #29354

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 6, 2020

Hi @konarshankar07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@konarshankar07
Copy link
Contributor Author

@magento run all tests

@konarshankar07
Copy link
Contributor Author

Do I need to write the MFTF test for this issue?
Thanks

@rogyar rogyar self-assigned this Aug 6, 2020
@rogyar
Copy link
Contributor

rogyar commented Aug 6, 2020

Hi @konarshankar07. Could I ask you to cover your change using an MFTF test? The idea of the test is to log in using the "Login as Customer" feature, scroll a page to the bottom and make sure that the banner is visible.

Thank you!

@rogyar rogyar added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Aug 6, 2020
@konarshankar07
Copy link
Contributor Author

@magento run all tests

@konarshankar07
Copy link
Contributor Author

konarshankar07 commented Aug 7, 2020 •
edited
Loading

Hello @rogyar ...
I have added MFTF test for this issue
Thanks

@konarshankar07
Copy link
Contributor Author

@magento run Static Tests

@konarshankar07
Copy link
Contributor Author

@magento run all tests

swnsma
swnsma previously approved these changes Aug 7, 2020
View reviewed changes
@ghost ghost assigned swnsma Aug 7, 2020
@swnsma swnsma added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: MFTF test coverage Progress: pending review and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Progress: ready for testing labels Aug 7, 2020
@konarshankar07
Copy link
Contributor Author

@magento run all tests

@m2-assistant m2-assistant bot mentioned this pull request Aug 18, 2020
Closed
4 tasks
@rogyar
Copy link
Contributor

rogyar commented Aug 19, 2020

Hi @konarshankar07. It looks like you've reverted the change related to my recommendation regarding cache flushing

https://github.com/magento/magento2/pull/29415/files#r467592914

@konarshankar07
Copy link
Contributor Author

@magento run all tests

@konarshankar07
Copy link
Contributor Author

@magento run all tests

@konarshankar07
Copy link
Contributor Author

@magento run WebAPI Tests

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7977 has been created to process this Pull Request

@engcom-Oscar engcom-Oscar self-assigned this Sep 3, 2020
@engcom-Oscar
Copy link

engcom-Oscar commented Sep 3, 2020 •
edited
Loading

✔️ QA Passed

Preconditions:

  1. Magento 2.4 installed.
  2. Enable 'Login as Customer' in configuration in admin

Steps to reproduce :

  1. Create customer account from Homepage, open created account and in 'Account information' enable 'Allow remote shopping assistance'.
  2. Login as admin to backend, go to Admin -> Customers -> All customers and enter in your created customer account
  3. Click on 'Login As Customer' button in header
  4. You redirected to Homepage logged-in as your customer account. Persistent banner 'You are connected as on Main Website' appears at top of screen.

Before ✖️

Banner is not "sticky." When user scrolls down on the page, banner scrolls out of view.

image

After ✔️

Banner is "sticky" and remains at top of screen when user scrolls down

image

@engcom-Delta engcom-Delta self-assigned this Sep 14, 2020
@engcom-Delta engcom-Delta added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Sep 14, 2020
@engcom-Delta
Copy link
Contributor

Note: Automation tests are passed

@sidolov sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Sep 14, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request Sep 14, 2020
Closed
1 task
magento-engcom-team pushed a commit that referenced this pull request Sep 14, 2020
@sidolov
ENGCOM-7977: #29354 :- Login as Customer storefront banner is not sti…
b075d5e 
…cky #29415
@magento-engcom-team magento-engcom-team merged commit bb051f2 into magento:2.4-develop Sep 14, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2020

Hi @konarshankar07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@swnsma swnsma Awaiting requested review from swnsma

Assignees

@rogyar rogyar

@swnsma swnsma

@engcom-Delta engcom-Delta

@engcom-Oscar engcom-Oscar

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: MFTF test coverage Component: LoginAsCustomer Component: LoginAsCustomerFrontendUi Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Project: Login as Customer QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Login as Customer storefront banner is not sticky
8 participants
@konarshankar07 @rogyar @magento-engcom-team @swnsma @engcom-Oscar @engcom-Delta @VladimirZaets @sidolov