Simplified media gallery AssetDetailsProvider implementation #29449

sivaschenko · 2020-08-09T16:52:46Z

Description (*)

Simplified media gallery AssetDetailsProvider implementation

Fixed Issues (if relevant)

Fixes Remove AssetDetailsProviderPool adobe-stock-integration#1726

Manual testing scenarios (*)

Add images from Media Gallery to Page, Block, Category and Product content
Go to Media Gallery (check on both embedded (opened from wysiwyg) and standalone (Content -> Media Gallery menu) Media Gallery)
View details of the images - the "Used In" information in View Details panel should be displayed correctly
Delete the images - entities, where the image is used in, should be mentioned in the deletion warning popup

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

… implementation

m2-assistant · 2020-08-09T16:52:48Z

Hi @sivaschenko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

sivaschenko · 2020-08-09T16:53:17Z

@magento run all tests

lbajsarowicz

Please review the comments.

lbajsarowicz · 2020-08-09T18:43:19Z

app/code/Magento/MediaGalleryUi/Model/GetAssetDetails.php

+     */
+    private function formatSize(int $imageSize): string
+    {
+        return $imageSize === 0 ? '' : sprintf('%sKb', $imageSize / 1000);


Kb is not a valid unit. Also - 1kB is 1024B
https://en.wikipedia.org/wiki/Kilobyte

Suggested change

return $imageSize === 0 ? '' : sprintf('%sKb', $imageSize / 1000);

return $imageSize === 0 ? '' : sprintf('%sKB', $imageSize / 1024);

Are you aware that when image size is 333B, then it'll display:

But also sprintf can format number of digits?
Eg. "%.2f"

What is more - \Zend\Validator\File\Size::toByteString offers exactly what you have done there.

Thanks, went with $size === 0 ? '' : sprintf('%.2f KB', $size / 1024);

app/code/Magento/MediaGalleryUi/Model/GetAssetUsageDetails.php

sivaschenko · 2020-08-10T10:57:40Z

@magento run all tests

sivaschenko · 2020-08-10T10:58:01Z

Thanks for the review @lbajsarowicz please check my updates/responses

lbajsarowicz

✔️ Looks fine for me.
We still need to wait for automated tests to finish.

magento-engcom-team · 2020-08-10T11:01:49Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7984 has been created to process this Pull Request

engcom-Lima

❌ QA Failed
Steps to Reproduce:

Add image from Media Gallery to Page, Block, Category and Product content
Go to Content -> Media Gallery
View details of the image
Click on the "Products" link in the "Used In" attribute

Expected Result: Products greed is opened
Actual Result: Page reloads (because of wrong url)

Note: With Blocks, Pages and Categories behavior the same. Enable the "Add secret key to URLs" option does not affect this

Pull Request state was updated. Re-review required.

sivaschenko · 2020-08-10T13:54:02Z

Thanks for testing, @engcom-Lima , the link URLs have been fixed

magento-engcom-team · 2020-08-10T14:01:34Z

Hi @gabrieldagama, thank you for the review.
ENGCOM-7984 has been created to process this Pull Request

sivaschenko · 2020-08-10T14:09:11Z

@magento run all tests

engcom-Lima · 2020-08-10T17:19:54Z

✔️ QA Passed
The "Used In" information in View Details panel is displayed correctly

Correct URLs

Delete the image

All cases covered by manual testing scenario

sivaschenko · 2020-08-11T11:52:05Z

@magento run all tests

slavvka · 2020-08-13T15:37:26Z

@magento run all tests

…tion #29449

m2-assistant · 2020-08-14T07:22:20Z

Hi @sivaschenko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento/adobe-stock-integration#1726: Simplified AssetDetailsProvider…

ee0dd0f

… implementation

ghost added the Progress: pending review label Aug 9, 2020

magento-engcom-team added Component: MediaGalleryCatalogUi Component: MediaGalleryUi Component: MediaGalleryCmsUi Release Line: 2.4 labels Aug 9, 2020

lbajsarowicz suggested changes Aug 9, 2020

View reviewed changes

ghost assigned lbajsarowicz Aug 9, 2020

ghost added Progress: needs update and removed Progress: pending review labels Aug 9, 2020

ghost assigned sivaschenko Aug 10, 2020

#29449: Corrected file size formatting

6f08422

lbajsarowicz previously approved these changes Aug 10, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 10, 2020

magento-engcom-team added the Release Line: 2.4 label Aug 10, 2020

ghost added Progress: testing in progress Progress: extended testing and removed Progress: ready for testing Progress: testing in progress labels Aug 10, 2020

ghost added the Progress: testing in progress label Aug 10, 2020

engcom-Lima self-assigned this Aug 10, 2020

engcom-Lima requested changes Aug 10, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: testing in progress labels Aug 10, 2020

#29449: Corrected link url retrieval

133913e

gabrieldagama approved these changes Aug 10, 2020

View reviewed changes

ghost assigned gabrieldagama Aug 10, 2020

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 10, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 10, 2020

engcom-Lima added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Aug 10, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Aug 10, 2020

sivaschenko added 2 commits August 11, 2020 12:51

#29449: Fixed tests

b0bce55

Merge branch '2.4-develop' into asset-details-provider-refactoring

8aec065

ghost added Progress: accept and removed Progress: extended testing labels Aug 12, 2020

Merge branch '2.4-develop' into asset-details-provider-refactoring

85aac6d

magento-engcom-team pushed a commit that referenced this pull request Aug 14, 2020

ENGCOM-7984: Simplified media gallery AssetDetailsProvider implementa…

0feba40

…tion #29449

magento-engcom-team merged commit c71f911 into magento:2.4-develop Aug 14, 2020

	return $imageSize === 0 ? '' : sprintf('%sKb', $imageSize / 1000);
	return $imageSize === 0 ? '' : sprintf('%sKB', $imageSize / 1024);

Simplified media gallery AssetDetailsProvider implementation #29449

Simplified media gallery AssetDetailsProvider implementation #29449

Uh oh!

Conversation

sivaschenko commented Aug 9, 2020

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Aug 9, 2020

Uh oh!

sivaschenko commented Aug 9, 2020

Uh oh!

lbajsarowicz left a comment

Choose a reason for hiding this comment

Uh oh!

lbajsarowicz Aug 9, 2020

Choose a reason for hiding this comment

Uh oh!

lbajsarowicz Aug 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lbajsarowicz Aug 9, 2020

Choose a reason for hiding this comment

Uh oh!

sivaschenko Aug 10, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sivaschenko commented Aug 10, 2020

Uh oh!

sivaschenko commented Aug 10, 2020

Uh oh!

lbajsarowicz left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Aug 10, 2020

Uh oh!

engcom-Lima left a comment

Choose a reason for hiding this comment

Uh oh!

sivaschenko commented Aug 10, 2020

Uh oh!

magento-engcom-team commented Aug 10, 2020

Uh oh!

sivaschenko commented Aug 10, 2020

Uh oh!

engcom-Lima commented Aug 10, 2020

Uh oh!

sivaschenko commented Aug 11, 2020

Uh oh!

slavvka commented Aug 13, 2020

Uh oh!

m2-assistant bot commented Aug 14, 2020

Uh oh!

Uh oh!

lbajsarowicz Aug 9, 2020 •

edited

Loading