Skip to content

#1387: "Uncaught TypeError: Cannot read property 'complete' of undefined" appears in dev console if save Previewed image as a new View and open this View on another page #29639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 26, 2020
Merged

#1387: "Uncaught TypeError: Cannot read property 'complete' of undefined" appears in dev console if save Previewed image as a new View and open this View on another page #29639

merged 6 commits into from
Aug 26, 2020

Conversation

joweecaquicla
Copy link

@joweecaquicla joweecaquicla commented Aug 18, 2020 •
edited
Loading

Description (*)

This PR will introduce the fix to prevent the error displaying in the console.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes "Uncaught TypeError: Cannot read property 'complete' of undefined" appears in dev console if save Previewed image as a new View and open this View on another page adobe-stock-integration#1387: "Uncaught TypeError: Cannot read property 'complete' of undefined" appears in dev console if save Previewed image as a new View and open this View on another page

Manual testing scenarios (*)

  1. Go to Content - Media Gallery
  2. Click Search Adobe Stock
  3. Go to the first page from the grid, and select any image to open its Preview
  4. Click on Default View (bookmarks view)
  5. Click Save View As...,
  6. Click Save all Changes ➡️
  7. Switch to the Default View
  8. Go to the second page in Adobe Stock grid
  9. Switch to the previously created New View

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

magento/adobe-stock-integration#1387: Uncaught TypeError: Cannot read…
154ebc0 
… property 'complete' of undefined appears in dev console if save Previewed image as a new View and open this View on another page - created separate function for loading of image data in preview
@m2-assistant
Copy link

m2-assistant bot commented Aug 18, 2020

Hi @joweecaquicla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@joweecaquicla joweecaquicla mentioned this pull request Aug 18, 2020
Closed
@sivaschenko sivaschenko added Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Aug 18, 2020
magento/adobe-stock-integration#1387: Uncaught TypeError: Cannot read…
61f5cbe 
… property 'complete' of undefined appears in dev console if save Previewed image as a new View and open this View on another page - suggested modifications
@joweecaquicla joweecaquicla changed the title [WIP] #1387: "Uncaught TypeError: Cannot read property 'complete' of undefined" appears in dev console if save Previewed image as a new View and open this View on another page #1387: "Uncaught TypeError: Cannot read property 'complete' of undefined" appears in dev console if save Previewed image as a new View and open this View on another page Aug 19, 2020
@joweecaquicla
Copy link
Author

@magento run all tests

sivaschenko
sivaschenko reviewed Aug 19, 2020
View reviewed changes
app/code/Magento/Ui/view/base/web/js/grid/columns/image-preview.js Outdated
/**
* Update displayed record
*
* @param items
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe missing paramter type will result in the static test failure

@ghost ghost assigned sivaschenko Aug 19, 2020
sivaschenko
sivaschenko reviewed Aug 19, 2020
View reviewed changes
app/code/Magento/Ui/view/base/web/js/grid/columns/image-preview.js Outdated

this.lastOpenedImage(record._rowIndex);
/**
* Update displayed record
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to make comments at least a bit more descriptive than method name if possible

Suggested change
* Update displayed record
* Update preview displayed record data from the new items data if the preview is expanded

magento/adobe-stock-integration#1387: Uncaught TypeError: Cannot read…
e2e6b3e 
… property 'complete' of undefined appears in dev console if save Previewed image as a new View and open this View on another page - requested modifications
@joweecaquicla
Copy link
Author

@magento run all tests

@sivaschenko sivaschenko mentioned this pull request Aug 19, 2020
Open
magento/adobe-stock-integration#1387: Uncaught TypeError: Cannot read…
d24d07d 
… property 'complete' of undefined appears in dev console if save Previewed image as a new View and open this View on another page - fix static test and unit test
@joweecaquicla
Copy link
Author

@magento run all tests

magento/adobe-stock-integration#1387: Uncaught TypeError: Cannot read…
a2f56ab 
… property 'complete' of undefined appears in dev console if save Previewed image as a new View and open this View on another page - modified function description
@joweecaquicla
Copy link
Author

@magento run all tests

magento/adobe-stock-integration#1387: Uncaught TypeError: Cannot read…
5ff347c 
… property 'complete' of undefined appears in dev console if save Previewed image as a new View and open this View on another page - fix static test fail
@joweecaquicla
Copy link
Author

@magento run all tests

@joweecaquicla
Copy link
Author

@magento run Functional Tests EE, Functional Tests B2B

@sivaschenko sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 25, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8065 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@chalov-anton chalov-anton self-assigned this Aug 25, 2020
@chalov-anton
Copy link
Contributor

✔️ QA Passed

The View is switched correctly:

  • switched to the correct page
  • image Preview is displayed

Manual testing scenario https://studio.cucumber.io/projects/131313/test-plan/folders/1337102/scenarios/5126336

@chalov-anton chalov-anton added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Aug 25, 2020
magento-engcom-team pushed a commit that referenced this pull request Aug 26, 2020
@sidolov
ENGCOM-8065: #1387: "Uncaught TypeError: Cannot read property 'comple…
0a1b9d9 
…te' of undefined" appears in dev console if save Previewed image as a new View and open this View on another page #29639
@magento-engcom-team magento-engcom-team merged commit 1c27106 into magento:2.4-develop Aug 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 26, 2020

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

@chalov-anton chalov-anton

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Ui Priority: P3 May be fixed according to the position in the backlog. Progress: accept Project: ASI QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
4 participants
@joweecaquicla @magento-engcom-team @chalov-anton @sivaschenko