[MFTF] Make AdminAssertCategoryGridPageDetailsActionGroup parametrized #29705

joweecaquicla · 2020-08-20T19:28:43Z

Description (*)

This PR will introduce the modifications to parameterized AdminAssertCategoryGridPageDetailsActionGroup

Related Pull Requests

Fixed Issues (if relevant)

Fixes [MFTF] Make AdminAssertCategoryGridPageDetailsActionGroup parametrized adobe-stock-integration#1775

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…GridPageDetailsActionGroup parametrized - initial modification

m2-assistant · 2020-08-20T19:28:46Z

Hi @joweecaquicla. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

…GridPageDetailsActionGroup parametrized - fix merge conflict

…GridPageDetailsActionGroup parametrized - modifications on enabled and in menu columns and mftf files

joweecaquicla · 2020-08-21T16:35:09Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

…GridPageDetailsActionGroup parametrized - additional modifications for in menu and enabled column renderer and mftf files

joweecaquicla · 2020-08-21T17:27:10Z

@magento run all tests

rogyar · 2020-08-24T09:39:47Z

...ediaGalleryCatalogUi/Test/Mftf/ActionGroup/AdminAssertCategoryGridPageDetailsActionGroup.xml

@@ -8,16 +8,19 @@
 <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
    <actionGroup name="AdminAssertCategoryGridPageDetailsActionGroup">


Good job!
I would suggest to use this opportunity and rename the action group to match the best practices:

Assert{Admin or Storefront}{Functionality}ActionGroup.xml

So the new name will be AssertAdminCategoryGridPageDetailsActionGroup
(see section 11.3.5 in the tech guidelines)

Thank you!

…GridPageDetailsActionGroup parametrized - renamed action group based on requested change

joweecaquicla · 2020-08-24T10:17:21Z

@magento run all tests

sivaschenko · 2020-08-24T12:06:32Z

app/code/Magento/MediaGalleryCatalogUi/Ui/Component/Listing/Columns/InMenu.php

@@ -24,9 +24,9 @@ public function prepareDataSource(array $dataSource)
            $fieldName = $this->getData('name');
            foreach ($dataSource['data']['items'] as & $item) {
                if (isset($item[$fieldName]) && $item[$fieldName] == 1) {
-                    $item[$fieldName] = 'Yes';
+                    $item[$fieldName] = '<span class="1">Yes</span>';


@joweecaquicla is there a way to go without the HTML in the column value? (changing only the MFTF part)

…75-parameterize-admin-assert-category-grid-page-details-action-group

…GridPageDetailsActionGroup parametrized - modified ui component and mftf files, additional action group for search by category name on category grid page

…GridPageDetailsActionGroup parametrized - introduced new ActionGroup and modified related mftf files

sivaschenko

Thanks for the updates @joweecaquicla ! Please see my comments

sivaschenko · 2020-08-26T12:43:13Z

...to/MediaGalleryCatalogUi/Test/Mftf/Section/AdminMediaGalleryCatalogUiCategoryGridSection.xml

@@ -9,14 +9,17 @@
 <sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
    <section name="AdminMediaGalleryCatalogUiCategoryGridSection">
+        <!--Search by category name element-->


I think it would be better to adjust the element names or introduce appropriate sections for the naming to be self-explanatory instead of using comments.

sivaschenko · 2020-08-26T12:44:16Z

...to/MediaGalleryCatalogUi/Test/Mftf/Section/AdminMediaGalleryCatalogUiCategoryGridSection.xml

@@ -9,14 +9,17 @@
 <sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
    <section name="AdminMediaGalleryCatalogUiCategoryGridSection">
+        <!--Search by category name element-->
+        <element name="search" type="input" selector=".admin__data-grid-header[data-bind='afterRender: \$data.setToolbarNode'] input[placeholder='Search by category name']"/>


Please do not use data-bind in a selector, that is part of the functionality implementation that can be changed

sivaschenko · 2020-08-26T12:48:13Z

...ode/Magento/MediaGalleryUi/Test/Mftf/Test/AdminEnhancedMediaGalleryVerifyAssetFilterTest.xml

-            <argument name="categoryName" value="$$category.name$$"/>
-        </actionGroup>
-        <actionGroup ref="ResetAdminDataGridToDefaultViewActionGroup" stepKey="resetAdminDataGridToDefaultView"/>
+        <grabTextFrom selector="{{AdminMediaGalleryCatalogUiCategoryGridSection.columnValue('Name')}}" stepKey="grabCategoryNameFromGrid"/>


I think it would be better to use the AssertAdminCategoryGridPageNumberOfRecordsActionGroup and AssertAdminCategoryGridPageDetailsActionGroup instead of custom verification

...lleryCatalogUi/Test/Mftf/Test/AdminMediaGalleryCatalogUiVerifyUsedInLinkCategoryGridTest.xml

...ediaGalleryCatalogUi/Test/Mftf/Test/AdminMediaGalleryCatalogUiVerifyCategoryGridPageTest.xml

sivaschenko · 2020-08-26T12:50:36Z

...leryCatalogUi/Test/Mftf/ActionGroup/AdminSearchCategoryGridPageByCategoryNameActionGroup.xml

+
+        <conditionalClick selector="{{AdminMediaGalleryCatalogUiCategoryGridSection.clearFilters}}" dependentSelector="{{AdminMediaGalleryCatalogUiCategoryGridSection.clearFilters}}" visible="true" stepKey="clickClearFilters"/>
+        <fillField selector="{{AdminMediaGalleryCatalogUiCategoryGridSection.search}}" userInput="{{categoryName}}" stepKey="fillKeywordSearchField"/>
+        <click selector="{{AdminMediaGalleryCatalogUiCategoryGridSection.submitSearch}}" stepKey="clickKeywordSearch"/>


Probably waiting for loader would be needed after applying the filter

sivaschenko · 2020-08-26T12:51:11Z

...ediaGalleryCatalogUi/Test/Mftf/ActionGroup/AssertAdminCategoryGridPageDetailsActionGroup.xml

+
+        <seeElement selector="{{AdminMediaGalleryCatalogUiCategoryGridSection.image(imageName)}}" stepKey="assertImageColumn"/>
+
+        <!--Name Column-->


I'd use stepKey for description of steps instead of comments

sivaschenko · 2020-08-26T12:52:07Z

...ediaGalleryCatalogUi/Test/Mftf/ActionGroup/AssertAdminCategoryGridPageDetailsActionGroup.xml

+    <actionGroup name="AssertAdminCategoryGridPageDetailsActionGroup">
+        <arguments>
+            <argument name="category"/>
+            <argument name="imageName" type="string" defaultValue="magento"/>


Let's move the image verification to a separate action group to have granular assets

sivaschenko · 2020-08-26T12:52:59Z

...ediaGalleryCatalogUi/Test/Mftf/ActionGroup/AssertAdminCategoryGridPageDetailsActionGroup.xml

+        <!--Products Column-->
+        <grabTextFrom selector="{{AdminMediaGalleryCatalogUiCategoryGridSection.columnValue('Products')}}" stepKey="grabProductsColumnValue"/>
+        <assertEquals stepKey="assertProductsColumn">
+            <expectedResult type="string">0</expectedResult>


Let's move the hardcoded verification to a separate action group with a proper name as this verification does not really depend on the category provided for this action group

…GridPageDetailsActionGroup parametrized - requested changes

…GridPageDetailsActionGroup parametrized - fix merge conflict

…GridPageDetailsActionGroup parametrized - modified mftf test file

joweecaquicla · 2020-08-26T16:57:29Z

@magento run all tests

…GridPageDetailsActionGroup parametrized - fix conflict

joweecaquicla · 2020-08-27T11:54:11Z

@magento run all tests

joweecaquicla · 2020-08-27T15:22:46Z

@magento run WebAPI Tests, Functional Tests EE, Functional Tests B2B

sivaschenko · 2020-08-28T10:39:10Z

@joweecaquicla great job!

magento-engcom-team · 2020-08-28T10:39:31Z

Hi @sivaschenko, thank you for the review.
ENGCOM-8095 has been created to process this Pull Request

m2-assistant · 2020-09-02T14:26:24Z

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team · 2020-11-03T17:08:50Z

Hi @rogyar, thank you for the review.
ENGCOM-8401 has been created to process this Pull Request

magento/adobe-stock-integration#1775: [MFTF] Make AdminAssertCategory…

f1271c0

…GridPageDetailsActionGroup parametrized - initial modification

joweecaquicla added the Project: ASI label Aug 20, 2020

joweecaquicla requested a review from sivaschenko August 20, 2020 19:28

ghost added the Progress: pending review label Aug 20, 2020

magento-engcom-team added Component: MediaGalleryCatalogUi Release Line: 2.4 labels Aug 20, 2020

sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 20, 2020

joweecaquicla added 2 commits August 22, 2020 00:12

magento/adobe-stock-integration#1775: [MFTF] Make AdminAssertCategory…

0cd1e55

…GridPageDetailsActionGroup parametrized - fix merge conflict

magento/adobe-stock-integration#1775: [MFTF] Make AdminAssertCategory…

228ebc5

…GridPageDetailsActionGroup parametrized - modifications on enabled and in menu columns and mftf files

magento/adobe-stock-integration#1775: [MFTF] Make AdminAssertCategory…

b44b046

…GridPageDetailsActionGroup parametrized - additional modifications for in menu and enabled column renderer and mftf files

rogyar self-assigned this Aug 24, 2020

rogyar reviewed Aug 24, 2020

View reviewed changes

magento/adobe-stock-integration#1775: [MFTF] Make AdminAssertCategory…

40cb692

…GridPageDetailsActionGroup parametrized - renamed action group based on requested change

sivaschenko reviewed Aug 24, 2020

View reviewed changes

ghost assigned sivaschenko Aug 24, 2020

joweecaquicla added 3 commits August 25, 2020 01:34

Merge branch '2.4-develop' of github.com:magento/magento2 into ASI-17…

2ad3c80

…75-parameterize-admin-assert-category-grid-page-details-action-group

magento/adobe-stock-integration#1775: [MFTF] Make AdminAssertCategory…

519f4ce

…GridPageDetailsActionGroup parametrized - modified ui component and mftf files, additional action group for search by category name on category grid page

magento/adobe-stock-integration#1775: [MFTF] Make AdminAssertCategory…

3c10b69

…GridPageDetailsActionGroup parametrized - introduced new ActionGroup and modified related mftf files

sivaschenko requested changes Aug 26, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: pending review labels Aug 26, 2020

magento/adobe-stock-integration#1775: [MFTF] Make AdminAssertCategory…

2279d2c

…GridPageDetailsActionGroup parametrized - requested changes

joweecaquicla changed the title ~~[WIP] #1775: [MFTF] Make AdminAssertCategoryGridPageDetailsActionGroup parametrized~~ #1775: [MFTF] Make AdminAssertCategoryGridPageDetailsActionGroup parametrized Aug 26, 2020

joweecaquicla requested a review from sivaschenko August 26, 2020 16:29

magento/adobe-stock-integration#1775: [MFTF] Make AdminAssertCategory…

da3fd1c

…GridPageDetailsActionGroup parametrized - fix merge conflict

magento/adobe-stock-integration#1775: [MFTF] Make AdminAssertCategory…

af2908b

…GridPageDetailsActionGroup parametrized - modified mftf test file

magento/adobe-stock-integration#1775: [MFTF] Make AdminAssertCategory…

43ecb4d

…GridPageDetailsActionGroup parametrized - fix conflict

sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 28, 2020

sivaschenko approved these changes Aug 28, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 28, 2020

magento-engcom-team added the Component: MediaGalleryUi label Aug 28, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 28, 2020

ghost added Progress: accept and removed Progress: testing in progress labels Aug 28, 2020

rogyar approved these changes Aug 31, 2020

View reviewed changes

sivaschenko changed the title ~~#1775: [MFTF] Make AdminAssertCategoryGridPageDetailsActionGroup parametrized~~ [MFTF] Make AdminAssertCategoryGridPageDetailsActionGroup parametrized Aug 31, 2020

magento-engcom-team merged commit 0de468d into magento:2.4-develop Sep 2, 2020


		<seeElement selector="{{AdminMediaGalleryCatalogUiCategoryGridSection.image(imageName)}}" stepKey="assertImageColumn"/>

		<!--Name Column-->

[MFTF] Make AdminAssertCategoryGridPageDetailsActionGroup parametrized #29705

[MFTF] Make AdminAssertCategoryGridPageDetailsActionGroup parametrized #29705

Uh oh!

Conversation

joweecaquicla commented Aug 20, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Aug 20, 2020

Uh oh!

joweecaquicla commented Aug 21, 2020

Uh oh!

joweecaquicla commented Aug 21, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joweecaquicla commented Aug 24, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sivaschenko left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joweecaquicla commented Aug 26, 2020

Uh oh!

joweecaquicla commented Aug 27, 2020

Uh oh!

joweecaquicla commented Aug 27, 2020

Uh oh!

sivaschenko commented Aug 28, 2020

Uh oh!

magento-engcom-team commented Aug 28, 2020

Uh oh!

m2-assistant bot commented Sep 2, 2020

Uh oh!

magento-engcom-team commented Nov 3, 2020

Uh oh!

Uh oh!