Skip to content

MediaGallery Set path column as text type #29742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2020
Merged

MediaGallery Set path column as text type #29742

merged 3 commits into from
Sep 2, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Aug 25, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Image won't upload to media gallery if subfolder has long name adobe-stock-integration#1778: Image won't upload to media gallery if subfolder has long name

Manual testing scenarios (*)

  1. Create a folder with 2 or more subfolders (folder and all subfolders have long names)
  2. Try uploading an image to the last subfolder (Or save from Adobe Stock)

Image uploaded

Questions or comments

Approval Request: https://jira.corp.magento.com/browse/MC-37018

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 25, 2020

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Aug 25, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 25, 2020

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8069 has been created to process this Pull Request

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 25, 2020

@magento run all tests

@sivaschenko
Copy link
Member

Tests have failed with error: Syntax error or access violation: 1170 BLOB/TEXT column 'path' used in key specification without a key length

@sivaschenko
Copy link
Member

@magento run all tests

@sivaschenko
Copy link
Member

SVC failure is approved

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

The images can be successfully uploaded into a subfolder with long name
Selection_070

Manual testing scenario - https://studio.cucumber.io/projects/131313/test-plan/folders/1337102/scenarios/5137316

@engcom-Bravo engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Aug 27, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 2, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@zakdma
Copy link
Contributor

zakdma commented Sep 21, 2020

@sivaschenko
Copy link
Member

@zakdma change s have been approved, see link in description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGallery Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Project: ASI QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Image won't upload to media gallery if subfolder has long name
7 participants