Skip to content

magento/magento2#29372: Wrong tags are set for CategoryList query #29751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pmarjan
Copy link
Contributor

@pmarjan pmarjan commented Aug 26, 2020

Split categoryList cache test classes

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes [GraphQL] Wrong tags are set for CategoryList query #29372

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Split categoryList cache test classes
@pmarjan pmarjan added Project: GraphQL PAP Partners acceleration program labels Aug 26, 2020
@pmarjan pmarjan added this to the 2.4.2 milestone Aug 26, 2020
@pmarjan pmarjan requested a review from cpartica August 26, 2020 13:03
@m2-assistant
Copy link

m2-assistant bot commented Aug 26, 2020

Hi @pmarjan. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@BarnyShergold
Copy link

@magento run all tests

@ghost ghost added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 27, 2020
@ghost ghost added the Progress: accept label Aug 31, 2020
@BarnyShergold BarnyShergold removed their assignment Sep 1, 2020
@magento-engcom-team magento-engcom-team merged commit 87fed9a into magento:2.4-develop Oct 4, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 4, 2020

Hi @pmarjan, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PAP Partners acceleration program Partner: Comwrap partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: GraphQL Release Line: 2.4
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[GraphQL] Wrong tags are set for CategoryList query
4 participants