Remove area emulation from media-content:sync command #29753

jmonteros422 · 2020-08-26T14:08:23Z

Description (*)

This PR Removes area emulation from \Magento\MediaContentSynchronization\Console\Command\Synchronize::execute

Fixed Issues (if relevant)

Fixes Remove area emulation from media-content:sync command adobe-stock-integration#1784: Remove area emulation from media-content:sync command

Testing

Add some images from media gallery to the content of category, product, page and block
Clear media_content_asset database table
Run media-content:sync command
Verify all Used In links are correctly displayed in the asset details

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…a-content:sync command - remove area emulation

m2-assistant · 2020-08-26T14:08:26Z

Hi @jmonteros422. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

jmonteros422 · 2020-08-26T14:08:43Z

@magento run all tests

magento-engcom-team · 2020-08-26T17:39:47Z

Hi @BarnyShergold, thank you for the review.
ENGCOM-8081 has been created to process this Pull Request
✳️ @BarnyShergold, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Bravo

❌ QA Failed

The synchronization works properly only once. But if you clear the media_content_asset table twice, the Used in will not display any records
Manua testing steps:

Add some images from media gallery to the content of category, product, page and block
Clear media_content_asset database table
Run media-content:sync command
Verify all Used In links are correctly displayed in the asset details
Clear media_content_asset database table one more time
Run media-content:sync command
Verify all Used In links are correctly displayed in the asset details

AR: The Used in section is not displayed in image details

sivaschenko

Thanks for the PR @jmonteros422 ! Please see my comment

sivaschenko · 2020-08-27T11:35:00Z

app/code/Magento/MediaContentSynchronization/Console/Command/Synchronize.php

@@ -58,12 +48,7 @@ protected function configure()
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $output->writeln('Synchronizing content with assets...');
-        $this->state->emulateAreaCode(


This emulation is used for Magento to generate proper links when searching for content usages. When removing the emulation - the links generation should be fixed

Pull Request state was updated. Re-review required.

engcom-Bravo

Request changes test

sivaschenko

Synchronization is not executed for entities that have not been updated since last sync execution, can you please update the entity before performing the second table cleanup and sync

magento-engcom-team · 2020-08-27T13:23:39Z

Hi @sivaschenko, thank you for the review.
ENGCOM-8081 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Bravo · 2020-08-28T14:55:54Z

✔️ QA Passed

Manual testing steps

Add some images from media gallery to the content of category, product, page and block
Clear media_content_asset database table
Run media-content:sync command
Verify all Used In links are correctly displayed in the asset details

The media content synchronization is covered in several scenarios on cucumber studio. There is no need to create a separate for this PR.

m2-assistant · 2020-09-02T14:26:19Z

Hi @jmonteros422, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento/adobe-stock-integration#1784: Remove area emulation from medi…

748f623

…a-content:sync command - remove area emulation

jmonteros422 added Project: ASI Component: MediaContentSynchronization labels Aug 26, 2020

ghost added the Progress: pending review label Aug 26, 2020

magento-engcom-team added the Release Line: 2.4 label Aug 26, 2020

BarnyShergold self-assigned this Aug 26, 2020

BarnyShergold previously approved these changes Aug 26, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: pending review labels Aug 26, 2020

jmonteros422 changed the title ~~[WIP]#1784: Remove area emulation from media-content:sync command~~ #1784: Remove area emulation from media-content:sync command Aug 27, 2020

jmonteros422 requested a review from sivaschenko August 27, 2020 04:09

engcom-Bravo self-assigned this Aug 27, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 27, 2020

engcom-Bravo reviewed Aug 27, 2020

View reviewed changes

ghost added Progress: ready for testing Progress: testing in progress and removed Progress: testing in progress Progress: ready for testing labels Aug 27, 2020

engcom-Bravo removed the Progress: testing in progress label Aug 27, 2020

ghost added the Progress: testing in progress label Aug 27, 2020

sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 27, 2020

sivaschenko requested changes Aug 27, 2020

View reviewed changes

ghost assigned sivaschenko Aug 27, 2020

ghost removed the Progress: testing in progress label Aug 27, 2020

ghost added the Progress: needs update label Aug 27, 2020

sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. labels Aug 27, 2020

engcom-Bravo requested changes Aug 27, 2020

View reviewed changes

sivaschenko approved these changes Aug 27, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Aug 27, 2020

sivaschenko added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 27, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 28, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Aug 28, 2020

engcom-Bravo added Progress: testing in progress QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed Progress: extended testing labels Aug 28, 2020

ghost added Progress: accept and removed Progress: testing in progress labels Aug 29, 2020

sivaschenko changed the title ~~#1784: Remove area emulation from media-content:sync command~~ Remove area emulation from media-content:sync command Aug 31, 2020

BarnyShergold removed their assignment Sep 1, 2020

magento-engcom-team merged commit eb00722 into magento:2.4-develop Sep 2, 2020

keharper mentioned this pull request Aug 5, 2021

Please explain new 'media-content:sync' and 'media-gallery:sync' commands from Magento 2.4.1 magento/devdocs#8845

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove area emulation from media-content:sync command #29753

Remove area emulation from media-content:sync command #29753

Uh oh!

jmonteros422 commented Aug 26, 2020

Uh oh!

m2-assistant bot commented Aug 26, 2020

Uh oh!

jmonteros422 commented Aug 26, 2020

Uh oh!

magento-engcom-team commented Aug 26, 2020

Uh oh!

engcom-Bravo left a comment

Uh oh!

sivaschenko left a comment

Uh oh!

sivaschenko Aug 27, 2020

Uh oh!

engcom-Bravo left a comment

Uh oh!

sivaschenko left a comment

Uh oh!

magento-engcom-team commented Aug 27, 2020

Uh oh!

engcom-Bravo commented Aug 28, 2020

Uh oh!

m2-assistant bot commented Sep 2, 2020

Uh oh!

Uh oh!

Remove area emulation from media-content:sync command #29753

Remove area emulation from media-content:sync command #29753

Uh oh!

Conversation

jmonteros422 commented Aug 26, 2020

Description (*)

Fixed Issues (if relevant)

Testing

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Aug 26, 2020

Uh oh!

jmonteros422 commented Aug 26, 2020

Uh oh!

magento-engcom-team commented Aug 26, 2020

Uh oh!

engcom-Bravo left a comment

Choose a reason for hiding this comment

Uh oh!

sivaschenko left a comment

Choose a reason for hiding this comment

Uh oh!

sivaschenko Aug 27, 2020

Choose a reason for hiding this comment

Uh oh!

engcom-Bravo left a comment

Choose a reason for hiding this comment

Uh oh!

sivaschenko left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Aug 27, 2020

Uh oh!

engcom-Bravo commented Aug 28, 2020

Uh oh!

m2-assistant bot commented Sep 2, 2020

Uh oh!

Uh oh!