Skip to content

Change the position of the main action buttons on View Details #29774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jmonteros422
Copy link
Contributor

Description (*)

This PR Changes the position order of the main action buttons based on UI Prototype

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Change the position of the main action buttons on View Details  adobe-stock-integration#1783: Change the position of the main action buttons on View Details

Preconditions (*)

  1. Installed Magento with Adobe Stock Integration
  2. Configured integration in Stores -> Configuration -> System -> Adobe Stock Integration fieldset
  3. Enhanced Media Gallery is enabled
  4. Image exists in Media Gallery

Manual testing scenarios (*)

  1. Go Content - Pages click Add New Page
  2. Expand Content click Show / Hide Editor, Insert Image...
  3. Select an image from Media Galley, click "three dots"
  4. Select View Details
  5. Check the position of the buttons on main-action

Expected Result (*)

The buttons should be in the order provided in UI Prototype
im_det_expected

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

… action buttons on View Details - change button order
@m2-assistant
Copy link

m2-assistant bot commented Aug 27, 2020

Hi @jmonteros422. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@jmonteros422
Copy link
Contributor Author

@magento run all tests

@sivaschenko sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Aug 27, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8084 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Checked on Standalone and not Standalone Media Galleries

order_buttons

Added test steps to already existing scenario - https://studio.cucumber.io/projects/131313/test-plan/folders/1054245/scenarios/4653671

@engcom-Bravo engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Aug 27, 2020
@sivaschenko sivaschenko changed the title #1783: Change the position of the main action buttons on View Details Change the position of the main action buttons on View Details Aug 31, 2020
@magento-engcom-team magento-engcom-team merged commit 745d38e into magento:2.4-develop Sep 2, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 2, 2020

Hi @jmonteros422, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: MediaGalleryUi Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: ASI QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Change the position of the main action buttons on View Details
4 participants