Skip to content

Fix filter placeholders for ui-select filter (frontend implementation) #29783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 2, 2020
Merged

Fix filter placeholders for ui-select filter (frontend implementation) #29783

merged 5 commits into from
Sep 2, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Aug 27, 2020 •
edited
Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes "Active filters" shows the "Asset:" filter which is empty if switch to the Default View again  adobe-stock-integration#1780: "Active filters" shows the "Asset:" filter which is empty if switch to the Default View again

Manual testing scenarios (*)

  1. Verify asset filter placeholders in grids -> product, pages, blocks, categories
  2. Verify asset filter placeholder with saved grid views in all listed grid (products,pages,blocks,categories)
  3. Verify asset filter placeholders from saved in bookmarks filters in listed grids products,pages,blocks,categories)
  4. Verify Used in filters place holders in standalone and slide panel media gallery with saved in bookmarks and saved in different grid views.
  5. Verify url-filter applier by link from image view details thats used in (products,pages,blocks,categories)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Aug 27, 2020

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@engcom-Golf
Copy link
Contributor

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 27, 2020

@magento run all tests

sivaschenko
sivaschenko requested changes Aug 27, 2020
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Nazar65 ! Looks awesome!

Please see my review comments.

Does the url-filter-applier works fine with these changes as well?

app/code/Magento/Ui/view/base/web/js/grid/filters/elements/ui-select.js Outdated
* Validate initial value actually exists
*/
validateInitialValue: function () {
if (!_.isEmpty(this.value())) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the condition to avoid the else condition

app/code/Magento/Catalog/Controller/Adminhtml/Product/GetSelected.php Outdated
'is_active' => $product->getStatus(),
'path' => $product->getSku(),
];
$productIds = $this->getRequest()->getParam('ids');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is backward incompatible change. Please keep this controller as it is and introduce a new controller to MediaGalleryCatalogUi module

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@ghost ghost assigned sivaschenko Aug 27, 2020
@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Aug 27, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Aug 27, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Aug 27, 2020

@magento run all tests

@ghost ghost removed the Progress: needs update label Aug 28, 2020
@sivaschenko
Copy link
Member

@Nazar65 nice job!

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8094 has been created to process this Pull Request

@engcom-Bravo engcom-Bravo self-assigned this Aug 28, 2020
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Checked the:

  • Asset filter placeholders in Product, Pages, Blocks, Categories grids ✔️
  • Asset filter placeholder with saved grid views in all listed grid (products,pages,blocks,categories) ✔️
  • Used in filters place holders in standalone and slide panel media gallery with saved in bookmarks and saved in different grid views ✔️

Manual testing scenario - https://studio.cucumber.io/projects/131313/test-plan/folders/1320712/scenarios/5146730

@engcom-Bravo engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Aug 31, 2020
@magento-engcom-team magento-engcom-team merged commit 5102559 into magento:2.4-develop Sep 2, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 2, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

@engcom-Bravo engcom-Bravo

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Component: MediaGalleryCatalogUi Component: MediaGalleryCmsUi Component: MediaGalleryUi Component: Ui Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: extended testing Project: ASI QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Active filters" shows the "Asset:" filter which is empty if switch to the Default View again
5 participants
@Nazar65 @engcom-Golf @sivaschenko @magento-engcom-team @engcom-Bravo