Fix saving default directory in the default bookmark of media gallery

[engcom-Golf]

Description (*)

Fixes issue saving default directory in the default bookmark of media gallery

Fixed Issues (if relevant)

1. Fixes Prevent saving default directory in the default bookmark of media gallery adobe-stock-integration#1813

Manual testing scenarios (*)

Preconditions (*)

Old Media Gallery is disabled in Stores Configuration

Steps to reproduce (*)

1. Open media gallery from the CMS page content
2. Click on "Default View" bookmark
3. Ensure that there are no applied filters

[m2-assistant]

Hi @engcom-Golf. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[engcom-Golf]

@magento run all tests

[sivaschenko]

Thanks for the PR @engcom-Golf ! Please see my comment. A couple of tags has to be added to the test annotation.

[sivaschenko]

Failed static tests:

requirePaddingNewlinesBeforeKeywords: Keyword `if` should have an empty line above it at app/code/Magento/MediaGalleryUi/view/adminhtml/web/js/directory/directoryTree.js :
   258 |
   259 |                return;
   260 |            }
---------------------^
   261 |            if (!_.isUndefined(this.bookmarks())) {
   262 |                if (!_.size(this.bookmarks().getViewData(this.bookmarks().defaultIndex))) {

[engcom-Golf]

@magento run Static Tests

[engcom-Golf]

@magento run Static Tests

[sivaschenko]

@magento run all tests

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-8194 has been created to process this Pull Request

[engcom-Bravo]

✔️ QA Passed

The Default View doesn't contain directory filter or any.
Checked with wysiwyg and catalog/category folders.

Manual testing scenario - https://studio.cucumber.io/projects/131313/test-plan/folders/1320712/scenarios/5199870

[sivaschenko]

@magento run Sample Data Tests EE,Functional Tests CE,Functional Tests EE,Functional Tests B2B

[m2-assistant]

Hi @engcom-Golf, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.