Fixed Issue #14633 Sub-admin role related issue in order view page in magento 2 admin #30001

hws47a · 2020-09-11T12:01:21Z

This PR is replacing #20903 with some code style fixes and improvements.

*All further description is copy-pasted from the previous PR

Description (*)

Fixed Issue #14633 Sub-admin role related issue in order view page in magento 2 admin

Fixed Issues (if relevant)

Fixes Sub-admin role related issue in order view page in magento 2 admin #14633: Sub-admin role related issue in order view page in magento 2 admin
...

Manual testing scenarios (*)

I have created one sub admin user from Magento admin. This user can only view orders, add a comment and operate on shipping. I gave some permissions for sub admin user. Please check the below image:

So as you can see I have disabled Invoice and Credit memo role of this sub-admin.
But when I logged in as sub admin and go to order view page.Sometime Pop will come with "Something Went Wrong" and sometimes js error comes in console

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

Update Creditmemos.php Update Shipments.php Update Creditmemos.php Update Invoices.php Update Invoices.php Update Creditmemos.php Update Shipments.php Update Creditmemos.php Update Invoices.php Update Creditmemos.php Update Creditmemos.php Made Requested Changes

…ssue-14633

m2-assistant · 2020-09-11T12:01:24Z

Hi @hws47a. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

ihor-sviziev

Hi @hws47a,
In general your changes looks good to me. Could you cover your changes with some type of tests?

ihor-sviziev · 2020-09-11T12:05:47Z

@magento run all tests

hws47a · 2020-09-11T12:10:13Z

@ihor-sviziev I have no problems writing unit tests for this. However, it'll have pretty limited value for this case.

MFTF tests will be more appropriate in this case, but not sure if'll have enough energy and time for that 🙂

ihor-sviziev · 2020-09-11T12:14:33Z

@hws47a I think there will be suitable mftf or integration tests. Please try to write tests, if you'll have any issues - we'll try to help you

app/code/Magento/Sales/Block/Adminhtml/Order/View/Tab/Creditmemos.php

app/code/Magento/Sales/Block/Adminhtml/Order/View/Tab/Invoices.php

app/code/Magento/Sales/Block/Adminhtml/Order/View/Tab/Shipments.php

ihor-sviziev · 2020-09-16T03:36:15Z

@magento run all tests

ihor-sviziev

Hi @hws47a,
About the test results:

SVC - ✔seems like false positive, reported an issue for that magento/magento-semver#50
functional tests - ✔seems like not related to changes from this PR.
static tests - ❌ could you fix these failures? Unfortunately we need to make changed files to pass static test, even if before
changing they weren't.

Could you also cover your changes with MFTF test(s)?

hws47a · 2020-09-16T13:37:26Z

@ihor-sviziev thanks for your checks.
I'll fix code styles today.
For MFTF I need some time to re-configure the local environment to make tests work, so probably need a few more days.

ihor-sviziev · 2020-09-16T13:39:10Z

@hws47a if you don't have env for running and writing MFTF tests I would recommend you https://warden.dev/, there is quite good and clear docs.

Pull Request state was updated. Re-review required.

engcom-Charlie · 2020-10-20T07:08:56Z

It needs to approve, SVC falls with errors:

Magento\Sales\Block\Adminhtml\Order\View\Tab\Shipments::getOrder [public] Method return typing changed.
Magento\Sales\Block\Adminhtml\Order\View\Tab\Creditmemos::__construct [public] Method has been added.
Magento\Sales\Block\Adminhtml\Order\View\Tab\Invoices::__construct [public] Method has been added.

hws47a · 2021-02-18T20:17:41Z

@engcom-Charlie @sidolov should it be closed?

sivaschenko · 2021-04-15T12:54:05Z

@magento run Semantic Version Checker

sivaschenko · 2021-04-15T12:57:19Z

Approval Request: https://jira.corp.magento.com/browse/MC-41920
Can be merged after the approval request is completed

magento-engcom-team · 2021-04-15T12:59:47Z

Hi @sivaschenko, thank you for the review.
ENGCOM-8351 has been created to process this Pull Request

sivaschenko · 2021-04-19T11:43:56Z

The SVC failure is approved

… view page in magento 2 admin #30001

m2-assistant · 2021-08-20T15:27:46Z

Hi @hws47a, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Govind Sharma and others added 3 commits February 22, 2019 19:16

Update Invoices.php

96bef4c

Update Creditmemos.php Update Shipments.php Update Creditmemos.php Update Invoices.php Update Invoices.php Update Creditmemos.php Update Shipments.php Update Creditmemos.php Update Invoices.php Update Creditmemos.php Update Creditmemos.php Made Requested Changes

Merge remote-tracking branch 'magento/2.4-develop' into 2.3-Develop-i…

e845244

…ssue-14633

Code style improvements for magento#14633

27ae51e

ghost added the Progress: pending review label Sep 11, 2020

magento-engcom-team added Component: Sales Release Line: 2.4 Partner: Monsoon partners-contribution Pull Request is created by Magento Partner labels Sep 11, 2020

hws47a requested a review from sivaschenko September 11, 2020 12:02

ihor-sviziev self-assigned this Sep 11, 2020

ihor-sviziev added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 11, 2020

ihor-sviziev requested changes Sep 11, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: pending review labels Sep 11, 2020

ihor-sviziev added the Award: bug fix label Sep 11, 2020

sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 11, 2020

engcom-Charlie self-assigned this Sep 14, 2020

ihor-sviziev requested changes Sep 14, 2020

View reviewed changes

ghost assigned hws47a Sep 14, 2020

magento#14633 make the changes backward compatible

963ff74

ihor-sviziev requested changes Sep 16, 2020

View reviewed changes

Additional code style fixes

6fa9f6b

engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Oct 19, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Oct 19, 2020

ghost added Progress: pending review Progress: to approve and removed Progress: extended testing Progress: pending review labels Oct 20, 2020

hws47a removed their assignment Feb 20, 2021

m2-community-project bot added Progress: review and removed Progress: to approve labels Feb 20, 2021

ihor-sviziev added the Progress: to approve label Feb 22, 2021

m2-community-project bot removed the Progress: review label Feb 22, 2021

sivaschenko approved these changes Apr 15, 2021

View reviewed changes

m2-community-project bot assigned sivaschenko Apr 15, 2021

m2-community-project bot added Progress: ready for testing Progress: pending approval and removed Progress: to approve Progress: ready for testing labels Apr 15, 2021

m2-community-project bot added Progress: accept and removed Progress: pending approval labels Apr 19, 2021

magento-engcom-team pushed a commit that referenced this pull request Aug 20, 2021

ENGCOM-8351: Fixed Issue #14633 Sub-admin role related issue in order…

1c6a627

… view page in magento 2 admin #30001

magento-engcom-team merged commit 431d1bb into magento:2.4-develop Aug 20, 2021

Fixed Issue #14633 Sub-admin role related issue in order view page in magento 2 admin #30001

Fixed Issue #14633 Sub-admin role related issue in order view page in magento 2 admin #30001

Uh oh!

Conversation

hws47a commented Sep 11, 2020 • edited by ihor-sviziev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Sep 11, 2020

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev commented Sep 11, 2020

Uh oh!

hws47a commented Sep 11, 2020

Uh oh!

ihor-sviziev commented Sep 11, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ihor-sviziev commented Sep 16, 2020

Uh oh!

ihor-sviziev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hws47a commented Sep 16, 2020

Uh oh!

ihor-sviziev commented Sep 16, 2020

Uh oh!

engcom-Charlie commented Oct 20, 2020

Uh oh!

hws47a commented Feb 18, 2021

Uh oh!

sivaschenko commented Apr 15, 2021

Uh oh!

sivaschenko commented Apr 15, 2021

Uh oh!

magento-engcom-team commented Apr 15, 2021

Uh oh!

sivaschenko commented Apr 19, 2021

Uh oh!

m2-assistant bot commented Aug 20, 2021

Uh oh!

Uh oh!

hws47a commented Sep 11, 2020 •

edited by ihor-sviziev

Loading

ihor-sviziev left a comment •

edited

Loading