-
Notifications
You must be signed in to change notification settings - Fork 9.4k
#30009 Resolve regression from CSP updates #30010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#30009 Resolve regression from CSP updates #30010
Conversation
Hi @mtbottens. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @mtbottens. Thank you for the fix. According to the definition of done all the changes should be covered by automated tests. I would ask you to cover this case with an MFTF test. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtbottens please, cover changes with automated test
@mtbottens could you please cover your changes by an automated test? Otherwise, we can't proceed with your PR. |
@magento run all tests |
@mtbottens could you please resolve conflict with mainline and look at #30010 (comment)? |
@mtbottens please resolve conflict with mainline and look at #30010 (comment). Otherwise, we can't proceed with your PR. |
@magento run all tests |
Hi @rogyar, thank you for the review. |
✔️ QA Passed Manual testing scenario
|
@magento run all tests |
Hi @mtbottens, thank you for your contribution! |
Description (*)
Resolves regression caused from: 4758b43#diff-64b5862c98e5392810d14d8c4d605cb5
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)