Skip to content

#30009 Resolve regression from CSP updates #30010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 13, 2020
Merged

#30009 Resolve regression from CSP updates #30010

merged 7 commits into from
Nov 13, 2020

Conversation

mtbottens
Copy link

Description (*)

Resolves regression caused from: 4758b43#diff-64b5862c98e5392810d14d8c4d605cb5

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Users can not assign widgets to individual categories/products #30009

Manual testing scenarios (*)

  1. Navigate to magento admin
  2. Create a widget
  3. Add widget to layered category pages
  4. Assign to specific categories
  5. Observe selector appears

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 11, 2020

Hi @mtbottens. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@rogyar
Copy link
Contributor

rogyar commented Sep 12, 2020

Hi @mtbottens. Thank you for the fix. According to the definition of done all the changes should be covered by automated tests. I would ask you to cover this case with an MFTF test.

Thank you!

@rogyar rogyar self-assigned this Sep 12, 2020
@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. and removed Priority: P3 May be fixed according to the position in the backlog. labels Sep 14, 2020
@sidolov sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 14, 2020
Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtbottens please, cover changes with automated test

@ghost ghost assigned sidolov Sep 14, 2020
@engcom-Echo engcom-Echo self-assigned this Sep 16, 2020
@engcom-Echo engcom-Echo removed their assignment Oct 2, 2020
@engcom-Charlie engcom-Charlie self-assigned this Oct 2, 2020
@engcom-Charlie
Copy link
Contributor

@mtbottens could you please cover your changes by an automated test? Otherwise, we can't proceed with your PR.
Thank you.

@mtbottens mtbottens requested a review from sidolov October 5, 2020 17:55
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@mtbottens could you please resolve conflict with mainline and look at #30010 (comment)?
Thank you.

@engcom-Charlie
Copy link
Contributor

@mtbottens please resolve conflict with mainline and look at #30010 (comment). Otherwise, we can't proceed with your PR.
Thank you.

@mtbottens
Copy link
Author

@magento run all tests

@ghost ghost assigned mtbottens Oct 22, 2020
@engcom-Charlie engcom-Charlie requested a review from rogyar October 23, 2020 11:39
@rogyar rogyar added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage labels Oct 27, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-8396 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Manual testing scenario

  1. Go to Content->Widgets
  2. Click on Add Widget button
  3. Select any widget type and Design theme
  4. Click 'Continue' button
  5. Scroll down and click on 'Add Layout Update' button
  6. Select 'Anchor Categories' from Display on drop down list
  7. Select 'Specific Categories' radio button

Before applying changes provided in this PR
before

After switching to this PR
Category selection

@engcom-Bravo engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Oct 27, 2020
@gabrieldagama
Copy link
Contributor

@magento run all tests

@m2-assistant
Copy link

m2-assistant bot commented Nov 13, 2020

Hi @mtbottens, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Component: Widget Partner: Blue Acorn iCi partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users can not assign widgets to individual categories/products
8 participants