Skip to content

Add to Cart mutations in GraphQl should consider Catalog Permissions #30019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2020
Merged

Add to Cart mutations in GraphQl should consider Catalog Permissions #30019

merged 1 commit into from
Oct 10, 2020

Conversation

pmarjan
Copy link
Contributor

@pmarjan pmarjan commented Sep 13, 2020 •
edited
Loading

Description (*)

Fixes #29930

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/328

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@pmarjan pmarjan added Project: GraphQL PAP Partners acceleration program labels Sep 13, 2020
@pmarjan pmarjan added this to the 2.4.2 milestone Sep 13, 2020
@pmarjan pmarjan requested a review from cpartica September 13, 2020 15:13
@pmarjan pmarjan self-assigned this Sep 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 13, 2020

Hi @pmarjan. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost unassigned pmarjan Sep 13, 2020
@magento-engcom-team magento-engcom-team added Partner: Comwrap partners-contribution Pull Request is created by Magento Partner labels Sep 13, 2020
@pmarjan pmarjan self-assigned this Sep 13, 2020
@pmarjan pmarjan mentioned this pull request Sep 17, 2020
Closed
@pmarjan
Copy link
Contributor Author

pmarjan commented Sep 26, 2020

@magento run all tests

cpartica
cpartica previously approved these changes Oct 7, 2020
View reviewed changes
app/code/Magento/QuoteGraphQl/Model/Resolver/AddProductsToCart.php
@@ -68,6 +78,9 @@ public function resolve(Field $field, $context, ResolveInfo $info, array $value

$cartItems = [];
foreach ($cartItemsData as $cartItemData) {
if (!$this->itemIsAllowedToCart($cartItemData, $context)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what's going to happen to the items that already exist in cart settings are changed after?
should we add some checks to placeOrder? is core doing that?

@ghost ghost assigned cpartica Oct 7, 2020
@ghost ghost dismissed cpartica’s stale review October 7, 2020 15:49

Pull Request state was updated. Re-review required.

@magento-engcom-team magento-engcom-team merged commit 8d413dd into magento:2.4-develop Oct 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 10, 2020

Hi @pmarjan, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpartica cpartica cpartica left review comments

@melnikovi melnikovi Awaiting requested review from melnikovi

@dthampy dthampy Awaiting requested review from dthampy

@prabhuram93 prabhuram93 Awaiting requested review from prabhuram93

@cspruiell cspruiell Awaiting requested review from cspruiell

Assignees

@cpartica cpartica

@pmarjan pmarjan

Labels
Component: QuoteGraphQl PAP Partners acceleration program Partner: Comwrap partners-contribution Pull Request is created by Magento Partner Progress: needs update Project: GraphQL Release Line: 2.4
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.

"Add to Cart" mutations in GraphQl should consider Catalog Permissions
3 participants
@pmarjan @cpartica @magento-engcom-team