Skip to content

Input type datetime is used in lib styles #30065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Input type datetime is used in lib styles #30065

merged 2 commits into from
Oct 7, 2020

Conversation

GrimLink
Copy link
Member

@GrimLink GrimLink commented Sep 15, 2020

Description (*)

By replacing the attribute selector input[type=datetime] for a less specific input type selector.
It will it not force us to override the lib styles for using a deprecated html input type.

This change will keep the old situation intact.
And adds support input[type=date] and input[type=datetime-local], for the form styling.

Fixed Issues (if relevant)

  1. Fixes Input type datetime is used in lib styles #30064

Manual testing scenarios (*)

None.
Magento 2 does not use this input type on the front-end.
The only place this attribute is found in, is in the lib/web/css/docs.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

datatime is deprecated!
@m2-assistant
Copy link

m2-assistant bot commented Sep 15, 2020

Hi @GrimLink. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@GrimLink
Copy link
Member Author

@magento run all tests

@sidolov sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Risk: low Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Sep 15, 2020
@ihor-sviziev ihor-sviziev self-assigned this Sep 16, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Progress: pending review labels Sep 16, 2020
@ghost ghost added the Progress: review label Sep 16, 2020
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests looks not related to changes form this PR.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8216 has been created to process this Pull Request

@ghost ghost assigned ptylek Sep 16, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-8216 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@engcom-Alfa engcom-Alfa added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Oct 2, 2020
@engcom-Bravo
Copy link
Contributor

Dev experience is required for testing of this PR. Please note that Manual testing has not been performed.

@engcom-Foxtrot engcom-Foxtrot self-assigned this Oct 6, 2020
@engcom-Foxtrot
Copy link
Contributor

Manual testing not required.

@engcom-Alfa engcom-Alfa added QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Oct 6, 2020
@magento-engcom-team magento-engcom-team merged commit 9e27d6c into magento:2.4-develop Oct 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 7, 2020

Hi @GrimLink, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@GrimLink GrimLink deleted the bugfix/outdated-form-element-in-style branch October 8, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Risk: low Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Input type datetime is used in lib styles
8 participants