-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Input type datetime is used in lib styles #30065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input type datetime is used in lib styles #30065
Conversation
datatime is deprecated!
Hi @GrimLink. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔ Approved.
Failing tests looks not related to changes form this PR.
Hi @ihor-sviziev, thank you for the review. |
Hi @ptylek, thank you for the review. |
@magento run all tests |
Dev experience is required for testing of this PR. Please note that Manual testing has not been performed. |
Manual testing not required. |
Hi @GrimLink, thank you for your contribution! |
Description (*)
By replacing the attribute selector
input[type=datetime]
for a less specific input type selector.It will it not force us to override the lib styles for using a deprecated html input type.
This change will keep the old situation intact.
And adds support
input[type=date]
andinput[type=datetime-local]
, for the form styling.Fixed Issues (if relevant)
Manual testing scenarios (*)
None.
Magento 2 does not use this input type on the front-end.
The only place this attribute is found in, is in the
lib/web/css/docs
.Contribution checklist (*)