Set correct discount package value for tablerate

[basvanpoppel]

Description (*)

This PR fixes the issue for the table rate carrier where the 'package value with discount' in the RateRequest is filled with the package value without the discount.

Currently, when you have a cart rule which sets a discount on the cart, the discount will not be used for the table rate.

Steps to reproduce:

1. Create a table rate based on subtotal, f.e. 5 euro from a subtotal of 0, free shipping from a subtotal of 100 euros.
2. Create a cart rule which sets a discount of 10% on cart, on subtotal only
3. Ensure you have an item in your cart which has the discount, with a value of between 105 euros.
4. The cart rule subtracts 10,5 from 105 - resulting in a total of 94,50. Shipping should be 5 euros as the subtotal now is below 100, but it's 0 because the price value without discount is used.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

1. Create a table rate based on subtotal, f.e. 5 euro from a subtotal of 0, free shipping from a subtotal of 100 euros.
2. Create a cart rule which sets a discount of 10% on cart, on subtotal only
3. Ensure you have an item in your cart which has the discount, with a value of between 105 euros.
4. The cart rule subtracts 10,5 from 105 - resulting in a total of 94,50. Shipping costs of 5 euros are applied, order total is 99,50.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Set correct discount package value for tablerate #30169: Set correct discount package value for tablerate

[m2-assistant]

Hi @basvanpoppel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[swnsma]

Hi @basvanpoppel!
Thank you for your pull request!
Could you please sign Adobe CLA before we can start reviewing your pull request?

[sidolov]

@magento create issue

[basvanpoppel]

Hi @swnsma I've signed the CLA.

Please let me know if more information is needed, I'm happy to provide it.

[swnsma]

Hi @basvanpoppel,

According to Magento Definition of Done all pull requests should have an auto tests coverage.
May I ask you to introduce an Integration or MFTF test scenario which could verify that bug in the PR can not be reproduced anymore?

[swnsma]

@magento run all tests

[basvanpoppel]

@magento run all tests

[basvanpoppel]

Hi @basvanpoppel,

According to Magento Definition of Done all pull requests should have an auto tests coverage.
May I ask you to introduce an Integration or MFTF test scenario which could verify that bug in the PR can not be reproduced anymore?

Hi @swnsma,

I've written a MFTF test scenario to verify that the issue won't be reproduced anymore.

I've ran all tests. The reports don't mention any issues related to this pull request.

[swnsma]

@magento run Functional Tests B2B, Functional Tests CE

[swnsma]

@magento run Functional Tests B2B

[swnsma]

@magento run Functional Tests B2B

[magento-engcom-team]

Hi @swnsma, thank you for the review.
ENGCOM-8308 has been created to process this Pull Request

[swnsma]

@magento run Functional Tests B2B

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Create a table rate based on subtotal, f.e. 5 $ from a subtotal of 0, free shipping from a subtotal of 100 $.

2. Create a cart price rule which sets a discount of 10% on the cart, on subtotal only;
3. Ensure you have an item in your cart which has the discount, with a value of between 105 $;

Before: ✖️ Shipping amount is 0 because the price value without discount is used.

After: ✔️ Shipping costs of 5 $ are applied

[engcom-Charlie]

@magento run all tests

[gabrieldagama]

@magento run all tests

[m2-assistant]

Hi @basvanpoppel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.