Clean code and remove whitespace in markup layered navigation filters #30333

mrtuvn · 2020-10-04T07:51:23Z

Description (*)

This pr aim to clean whitespace in some inline elements inside layered filter items. Also update use $escaper instead $block in template

Related Pull Requests

Fixed Issues (if relevant)

Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

...
...

Questions or comments

Luma theme
Results before change

Results after change

Blank theme
Results before change

Results after change

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Clean code and remove whitespace in markup layered navigation filters #30448: Clean code and remove whitespace in markup layered navigation filters

m2-assistant · 2020-10-04T07:51:25Z

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

ihor-sviziev · 2020-10-05T07:16:42Z

@magento run all tests

ihor-sviziev

In general looks good. Have only one suggestion

app/code/Magento/LayeredNavigation/view/frontend/templates/layer/filter.phtml

mrtuvn · 2020-10-05T11:33:36Z

@magento run Static Tests

mrtuvn · 2020-10-05T12:23:10Z

@magento run all tests

ihor-sviziev

✔ Approved.

Failing tests looks not related to changes form this PR.

magento-engcom-team · 2020-10-05T16:56:37Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8309 has been created to process this Pull Request

ihor-sviziev · 2020-10-08T18:03:11Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

up

mrtuvn · 2020-10-09T00:59:58Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

mrtuvn · 2020-10-09T04:22:01Z

@magento run Database Compare, Integration Tests, Magento Health Index, Sample Data Tests CE, Sample Data Tests EE, Sample Data Tests B2B, Static Tests, Unit Tests, WebAPI Tests

mrtuvn · 2020-10-09T04:22:47Z

@magento run Semantic Version Checker

ihor-sviziev · 2020-10-09T17:55:18Z

@magento run Functional Tests CE, Functional Tests EE

magento-engcom-team · 2020-10-09T17:57:39Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8309 has been created to process this Pull Request

engcom-Alfa · 2020-10-12T09:28:45Z

@magento create issue

engcom-Alfa · 2020-10-12T09:33:33Z

✔️ QA Passed

Luma:

Before: ✖️

After: ✔️

The same results and on the Blank theme

…ation filters #30333

m2-assistant · 2020-10-13T11:17:25Z

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

ghost added the Progress: pending review label Oct 4, 2020

magento-engcom-team added Area: Frontend Component: LayeredNavigation Release Line: 2.4 labels Oct 4, 2020

ihor-sviziev self-assigned this Oct 5, 2020

ihor-sviziev added the Progress: review label Oct 5, 2020

ghost removed the Progress: pending review label Oct 5, 2020

ihor-sviziev reviewed Oct 5, 2020

View reviewed changes

app/code/Magento/LayeredNavigation/view/frontend/templates/layer/filter.phtml Outdated Show resolved Hide resolved

ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Oct 5, 2020

mrtuvn force-pushed the clean-whitespace-inside-layer-navigation-items branch from d551b8d to 9e88f96 Compare October 5, 2020 11:32

sidolov added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Oct 5, 2020

ihor-sviziev approved these changes Oct 5, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: review labels Oct 5, 2020

Clean code and remove whitespace in markup

374593d

up

mrtuvn force-pushed the clean-whitespace-inside-layer-navigation-items branch from 9e88f96 to 374593d Compare October 9, 2020 00:59

ihor-sviziev approved these changes Oct 9, 2020

View reviewed changes

mrtuvn mentioned this pull request Oct 10, 2020

Design issue fixed in category page magento2#30397 #30406

Closed

engcom-Alfa self-assigned this Oct 12, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Oct 12, 2020

m2-assistant bot mentioned this pull request Oct 12, 2020

[Issue] Clean code and remove whitespace in markup layered navigation filters #30448

Closed

4 tasks

engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Oct 12, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Oct 12, 2020

engcom-Foxtrot self-assigned this Oct 12, 2020

ghost added Progress: accept and removed Progress: extended testing labels Oct 12, 2020

magento-engcom-team pushed a commit that referenced this pull request Oct 13, 2020

ENGCOM-8309: Clean code and remove whitespace in markup layered navig…

7054f6e

…ation filters #30333

magento-engcom-team merged commit e8bfc12 into magento:2.4-develop Oct 13, 2020

mrtuvn deleted the clean-whitespace-inside-layer-navigation-items branch October 13, 2020 14:05

Clean code and remove whitespace in markup layered navigation filters #30333

Clean code and remove whitespace in markup layered navigation filters #30333

Uh oh!

Conversation

mrtuvn commented Oct 4, 2020 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Oct 4, 2020

Uh oh!

ihor-sviziev commented Oct 5, 2020

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mrtuvn commented Oct 5, 2020

Uh oh!

mrtuvn commented Oct 5, 2020

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Oct 5, 2020

Uh oh!

ihor-sviziev commented Oct 8, 2020

Uh oh!

mrtuvn commented Oct 9, 2020

Uh oh!

mrtuvn commented Oct 9, 2020

Uh oh!

mrtuvn commented Oct 9, 2020

Uh oh!

ihor-sviziev commented Oct 9, 2020

Uh oh!

magento-engcom-team commented Oct 9, 2020

Uh oh!

engcom-Alfa commented Oct 12, 2020

Uh oh!

engcom-Alfa commented Oct 12, 2020

Uh oh!

m2-assistant bot commented Oct 13, 2020

Uh oh!

Uh oh!

mrtuvn commented Oct 4, 2020 •

edited by m2-assistant bot

Loading