30349: Product filter with category_id does not work as expected - fi… #30375

sudheers-kensium · 2020-10-08T11:40:38Z

Product filter with category_id does not work as expected

Description (*)

Create 2 categories with 1 product each
run query to fetch products in those categories
{ products(filter: {category_id: {in: ["<cat1>", "<cat2>"]}}) { items { sku name } total_count } }
Should display total_count should be 2, and items should contain 2 products

Related Pull Requests

Fixed Issues (if relevant)

Fixes [PAP] Product filter with "category_id: {in: [...]}" does not work as expected #30349

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…xed total_count and items issues

m2-assistant · 2020-10-08T11:40:41Z

Hi @sudheers-kensium. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

rogyar · 2020-10-09T13:54:06Z

...odel/Resolver/Products/SearchCriteria/CollectionProcessor/FilterProcessor/CategoryFilter.php

@@ -61,7 +61,6 @@ public function apply(Filter $filter, AbstractDb $collection)
            $category = $this->categoryFactory->create();
            $this->categoryResourceModel->load($category, $categoryId);
            $categoryProducts[$categoryId] = $category->getProductCollection()->getAllIds();
-            $collection->addCategoryFilter($category);


Hi @sudheers-kensium. Thank you for your contribution. I'm not sure that by removing this filter we won't introduce an additional issue. This filter has been recently added for solving the sorting issue. Details are below

dfcf474#diff-8a27c9476b188f4e8830e9872984bdfbR64

@cpartica could you provide more information on the consequences, please? Unfortunately, I have a lack of details about MC-32278.

Thank you!

@rogyar I have changed the code. Please check once.

engcom-Charlie · 2020-10-12T07:25:08Z

Hi @sudheers-kensium, can you please look at #30375 (comment)? Otherwise, we can't proceed with your PR.
Thank you.

…xed query returns missing items

nrkapoor · 2020-10-14T11:07:17Z

@magento run all tests

rogyar · 2020-10-17T15:41:09Z

Hi @sudheers-kensium. Thanks for the adjustments. Now it looks much better.
Could you, please, cover this case with an API-functional test?

Thank you!

…ded API functional test

sudheers-kensium · 2020-10-20T07:20:21Z

Hi @rogyar. I have added API-functional test. Please check once.

sudheers-kensium · 2020-10-20T07:41:36Z

@magento run all tests

prabhuram93 · 2020-10-21T13:56:54Z

@magento run integration tests

sudheers-kensium · 2020-10-21T14:01:18Z

@magento run Integration Tests

dthampy · 2020-10-22T21:55:40Z

@magento import PR to magento-honey-badgers/magento2ce

magento-engcom-team · 2020-10-22T21:57:47Z

@dthampy the branch with code successfully imported intomagento-honey-badgers/magento2ce repository. Branch name: imported-magento-magento2-30375.

magento-engcom-team · 2020-10-27T08:39:50Z

Hi @rogyar, thank you for the review.
ENGCOM-8392 has been created to process this Pull Request

cpartica · 2020-10-29T17:07:00Z

@magento import PR to magento-honey-badgers/magento2ce

magento-engcom-team · 2020-10-29T17:43:19Z

@cpartica the branch with code successfully imported intomagento-honey-badgers/magento2ce repository. Branch name: imported-magento-magento2-30375.

m2-assistant · 2020-11-03T05:26:26Z

Hi @sudheers-kensium, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

rani-priya

@rogyar @cpartica and @prabhuram93 could you please review my observation

rani-priya · 2021-04-01T09:06:29Z

app/code/Magento/CatalogGraphQl/Model/Resolver/Products/DataProvider/ProductSearch.php

@@ -113,7 +113,7 @@ public function getList(
        $searchResults = $this->searchResultsFactory->create();
        $searchResults->setSearchCriteria($searchCriteriaForCollection);
        $searchResults->setItems($collection->getItems());
-        $searchResults->setTotalCount($searchResult->getTotalCount());
+        $searchResults->setTotalCount($collection->getSize());


Hi @sudheers-kensium ,

Here why we have changed $searchResult->getTotalCount() to $collection->getSize() ?

Actually my concern is when we call getSize() on collection then it will execute one sql query to the database and it will take some time but in $searchResult is itself an object and all the data is present in that object. so, to execute $searchResult->getTotalCount() system will take negligible time where as $collection->getSize() will take some time.

I checked the performance of both code by adding below code in /vendor/magento/module-catalog-graph-ql/Model/Resolver/Products/DataProvider/ProductSearch.php file of "getList" method after "$this->collectionPostProcessor->process($collection, $attributes);" code and checked the response time of both getSize and getTotalCount method.
$time1 = microtime(true);
echo "Total Count: ".$collection->getSize()."
";
$time2 = microtime(true);
echo "time taken in getSize is: ".($time2- $time1)."
";

$time3 = microtime(true);
echo "Total Count: ".$searchResult->getTotalCount()."
";
$time4 = microtime(true);
echo "time taken in getTotalCount is: ".($time4 - $time3);
Response on my local :
Total Count: 32310
time taken in getSize is: 3.1487860679626
Total Count: 32310
time taken in getTotalCount is: 3.4093856811523E-5

rani-priya · 2021-04-07T05:10:12Z

@magento give me 2.4-develop instance

magento-deployment-service · 2021-04-07T05:10:14Z

Hi @rani-webkul. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2021-04-07T05:15:50Z

Hi @rani-webkul, here is your Magento Instance: https://ba7f2d19bd12e7c6503a3b919866d314-2-4-develop.instances.magento-community.engineering
Admin access: https://ba7f2d19bd12e7c6503a3b919866d314-2-4-develop.instances.magento-community.engineering/admin_d2f4
Login: 0db3b0fc
Password: d3e6599c06a4

drpayyne · 2021-04-15T09:13:27Z

@rogyar @cpartica and @prabhuram93 could you please review my observation

Hi @rogyar, could you please check the above observation by @rani-webkul? Looks like it might cause performance issues when scaling up.

30349: Product filter with category_id does not work as expected - fi…

1c1e70e

…xed total_count and items issues

ghost added the Progress: pending review label Oct 8, 2020

magento-engcom-team added Component: CatalogGraphQl Release Line: 2.4 Partner: Kensium Solutions LLC partners-contribution Pull Request is created by Magento Partner labels Oct 8, 2020

sudheers-kensium requested a review from prabhuram93 October 8, 2020 11:41

sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Oct 8, 2020

rogyar self-assigned this Oct 9, 2020

rogyar requested changes Oct 9, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: pending review labels Oct 9, 2020

engcom-Charlie self-assigned this Oct 12, 2020

30349: Product filter with category_id does not work as expected - fi…

dd159ef

…xed query returns missing items

ghost assigned sudheers-kensium Oct 14, 2020

nrkapoor linked an issue Oct 14, 2020 that may be closed by this pull request

GraphQl products query returns missing items on using category_id filter with in array #29720

Closed

5 tasks

nrkapoor requested review from cpartica and melnikovi October 14, 2020 11:07

nrkapoor added the Project: GraphQL label Oct 14, 2020

nrkapoor added this to the 2.4.2 milestone Oct 14, 2020

engcom-Charlie removed their assignment Oct 15, 2020

rogyar added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Oct 17, 2020

30349: Product filter with category_id does not work as expected - ad…

fcaa729

…ded API functional test

cpartica added the PAP Partners acceleration program label Oct 21, 2020

prabhuram93 approved these changes Oct 22, 2020

View reviewed changes

ghost assigned prabhuram93 Oct 22, 2020

ghost added Progress: ready for testing and removed Progress: needs update labels Oct 22, 2020

rogyar added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Oct 27, 2020

rogyar approved these changes Oct 27, 2020

View reviewed changes

cpartica approved these changes Oct 29, 2020

View reviewed changes

ghost assigned cpartica Oct 29, 2020

ghost added Progress: accept and removed Progress: ready for testing labels Oct 29, 2020

magento-engcom-team merged commit f9706db into magento:2.4-develop Nov 3, 2020

engcom-Bravo mentioned this pull request Jan 25, 2021

Category filter IN doesn't work in graphQL. #31812

Closed

rani-priya reviewed Apr 1, 2021

View reviewed changes

m2-community-project bot assigned rani-priya Apr 1, 2021

m2-community-project bot removed the Progress: accept label Apr 1, 2021

rani-priya mentioned this pull request Apr 20, 2021

Performance of products graphql query getting degraded in magento 2.4.2 version #32791

Closed

30349: Product filter with category_id does not work as expected - fi… #30375

30349: Product filter with category_id does not work as expected - fi… #30375

Uh oh!

Conversation

sudheers-kensium commented Oct 8, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Oct 8, 2020

Uh oh!

rogyar Oct 9, 2020

Choose a reason for hiding this comment

Uh oh!

sudheers-kensium Oct 14, 2020

Choose a reason for hiding this comment

Uh oh!

engcom-Charlie commented Oct 12, 2020

Uh oh!

nrkapoor commented Oct 14, 2020

Uh oh!

rogyar commented Oct 17, 2020

Uh oh!

sudheers-kensium commented Oct 20, 2020

Uh oh!

sudheers-kensium commented Oct 20, 2020

Uh oh!

prabhuram93 commented Oct 21, 2020

Uh oh!

sudheers-kensium commented Oct 21, 2020

Uh oh!

dthampy commented Oct 22, 2020

Uh oh!

magento-engcom-team commented Oct 22, 2020

Uh oh!

magento-engcom-team commented Oct 27, 2020

Uh oh!

cpartica commented Oct 29, 2020

Uh oh!

magento-engcom-team commented Oct 29, 2020

Uh oh!

m2-assistant bot commented Nov 3, 2020

Uh oh!

rani-priya left a comment

Choose a reason for hiding this comment

Uh oh!

rani-priya Apr 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rani-priya commented Apr 7, 2021

Uh oh!

magento-deployment-service bot commented Apr 7, 2021

Uh oh!

magento-deployment-service bot commented Apr 7, 2021

Uh oh!

drpayyne commented Apr 15, 2021

Uh oh!

Uh oh!

rani-priya Apr 1, 2021 •

edited

Loading