Skip to content

magento/magento2#30408: solved multishipping cart item subtotal updat… #30411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 13, 2020
Merged

magento/magento2#30408: solved multishipping cart item subtotal updat… #30411

merged 8 commits into from
Nov 13, 2020

Conversation

sanjay-wagento
Copy link
Contributor

Description (*)

Multishipping does not update cart item subtotal correctly

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Multishipping does not update cart item subtotal correctly #30408

Manual testing scenarios (*)

  1. Add product in the cart
  2. Click on Check Out with Multiple Addresses Link
  3. Back to the cart page
  4. Update product qty and click on Update Shopping Cart

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 10, 2020

Hi @sanjay-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Multishipping Release Line: 2.4 Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Oct 10, 2020
@vijay-wagento
Copy link

#dmcdindia2020

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Oct 10, 2020
@gabrieldagama gabrieldagama self-assigned this Oct 10, 2020
@gabrieldagama
Copy link
Contributor

@magento run all tests

@gabrieldagama
Copy link
Contributor

@magento run Functional Tests CE,Functional Tests EE,Functional Tests B2B

gabrieldagama
gabrieldagama suggested changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@gabrieldagama gabrieldagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sanjay-wagento, thanks for your contribution, can you please have a look at my comment below?

Also, we need to add an automated test to cover this change in order to proceed with this PR.

Thanks.

@engcom-Hotel engcom-Hotel self-assigned this Oct 20, 2020
@engcom-Hotel
Copy link
Contributor

Will help here.

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@gabrieldagama gabrieldagama added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Progress: review labels Nov 9, 2020
@magento-engcom-team
Copy link
Contributor

Hi @gabrieldagama, thank you for the review.
ENGCOM-8442 has been created to process this Pull Request

@engcom-Bravo engcom-Bravo self-assigned this Nov 9, 2020
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Manual testing scenario

1.Enable Allow shipping for Multiple addresses
allow_shipping

  1. Go to store and login as customer

  2. Add product to cart
    1

  3. Click on Check Out with Multiple Addresses Link

  4. Click Back to the Shopping Cart
    2

  5. Update product qty and click on Update Shopping Cart

Actual result on Magento 2.4.0
Subtotal was not updated
subtotal_240

After applying changes provided in this PR
The Subtotal is updated correctly
Shopping cart_after

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Bravo engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Nov 10, 2020
@gabrieldagama gabrieldagama mentioned this pull request Nov 13, 2020
Closed
3 tasks
magento-engcom-team pushed a commit that referenced this pull request Nov 13, 2020
@gabrieldagama
ENGCOM-8442: #30408: solved multishipping cart item subtotal updat… #…
3f02c8a 
…30411
@magento-engcom-team magento-engcom-team merged commit f5fb564 into magento:2.4-develop Nov 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 13, 2020

Hi @sanjay-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Bravo engcom-Bravo engcom-Bravo left review comments

@engcom-Hotel engcom-Hotel engcom-Hotel left review comments

@gabrieldagama gabrieldagama gabrieldagama approved these changes

Assignees

@gabrieldagama gabrieldagama

@engcom-Bravo engcom-Bravo

@engcom-Hotel engcom-Hotel

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Multishipping Event: dmcdindia2020 Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multishipping does not update cart item subtotal correctly
6 participants
@sanjay-wagento @vijay-wagento @gabrieldagama @engcom-Hotel @magento-engcom-team @engcom-Bravo