Skip to content

XSD URN format #30530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2020
Merged

XSD URN format #30530

merged 2 commits into from
Oct 24, 2020

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Oct 17, 2020

Description (*)

Updated XSD URN format in XML files.

Related Pull Requests

N/A

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] XSD URN format #30552: XSD URN format

@m2-assistant
Copy link

m2-assistant bot commented Oct 17, 2020

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 18, 2020
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Integration Tests

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Integration Tests, Performance Acceptance Tests

@sidolov sidolov added Cleanup Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 19, 2020
@sidolov
Copy link
Contributor

sidolov commented Oct 19, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Oct 19, 2020
4 tasks
@ihor-sviziev
Copy link
Contributor

Seems like test failures are not related to changes from this PR. Let's wait a bit

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Integration Tests

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8360 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Oct 21, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@sivaschenko
Copy link
Member

@magento run Performance Acceptance Tests

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

magento-engcom-team pushed a commit that referenced this pull request Oct 24, 2020
@magento-engcom-team magento-engcom-team merged commit 5962fda into magento:2.4-develop Oct 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 24, 2020

Hi @mage2pratik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mage2pratik mage2pratik deleted the patch-14 branch March 26, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Issue] XSD URN format
7 participants