[Fixed-30537] - Bug in the Captcha extension #30537

[chiranjeevi-cj]

Description (*)

Replaced the misplaced bracket in the defaultCaptcha.js file

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Bug in the Captcha extension  #30537

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @chiranjeevi-cj. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

Hi @chiranjeevi-cj,

1. According to issue description - this issue isn't reproducing on 2.4-develop branch (info was added during issue verification). Is that correct? Could you check that?
2. In case if issue still reproducing on 2.4-develop - could you also cover your change with automated test?
3. Could you sign Adobe CLA in order to allow accepting PRs from you?

PS: The fix seems correct to me, just not clear why it's not reproducing

[engcom-Charlie]

@chiranjeevi-cj could you please provide steps to reproduce the issue on the latest 2.4-develop?
Thank you

[chiranjeevi-cj]

Hello @ihor-sviziev,
This issue isn't producing on the 2.4-develop branch. Can I decline this PR?

[engcom-Charlie]

@chiranjeevi-cj I have to close this PR because the issue mentioned above doesn't exist on 2.4-develop.
Thank you for your collaboration.

[m2-assistant]

Hi @chiranjeevi-cj, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[ihor-sviziev]

@chiranjeevi-cj it's really interesting... Could you investigate why it's not reproducing? How it was solved?
I still believe the following code is not correct and should be fixed:

magento2/app/code/Magento/Captcha/view/frontend/web/js/view/checkout/defaultCaptcha.js

Line 59 in d483e88

!_.isEmpty(captchaData)[formId] &&