[GraphQL] Fixed exposing special price

[rogyar]

Description (*)

This PR contains a fix for the scenario when GraphQL API exposes product special price when the special price period set for the future.

Fixed Issues (if relevant)

1. Magento 2.4.0 graphql leak data on special price #30210 : Magento 2.4.0 graphql leak data on special price
2. [2.3.5-p2] GraphQl Special Price Ignore's special price from to dates. #29631 : GraphQl Special Price Ignore's special price from to dates

Manual testing scenarios (*)

1. Create a product with a special price
2. Set the special price From and To date for the far future
3. Use the following query to retrieve the information about special price (change the filter parameters for your setup)

{
  products(filter: {name: {match: "Simple"}}) {
    items {
      name
      special_price
    }
  }
}

Expected result

{
  "data": {
    "products": {
      "items": [
        {
          "name": "Simple",
          "special_price": null
        }
      ]
    }
  }
}

The special_price should be null in case if the current date is not in the period set for the special price.

[m2-assistant]

Hi @rogyar. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[rogyar]

Working on the test coverage

[rogyar]

@magento run all tests

[rogyar]

I will get back to this PR tomorrow.

[rogyar]

@magento run all tests

[rogyar]

The failing tests don't seem to be related to the current change. We may proceed with the review.

[eduard13]

Good job 👍

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-8477 has been created to process this Pull Request

[eduard13]

@magento run Integration Tests, Functional Tests B2B, Functional Tests CE, Functional Tests EE

[eduard13]

@magento run Functional Tests EE

[eduard13]

@magento run Functional Tests EE

[cpartica]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[cpartica]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[m2-assistant]

Hi @rogyar, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.