Skip to content

[GraphQL] Add possibility to filter categories by parent_id #30630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rogyar
Copy link
Contributor

@rogyar rogyar commented Oct 23, 2020

Description (*)

This PR introduces a possibility to filter the result set of categories by parent_id

Fixed Issues (if relevant)

  1. [GraphQL] Add parent_id to filters for subcategory pagination #30624 : Add parent_id to filters for subcategory pagination

Manual testing scenarios (*)

  1. Create a set of categories and subcategories for your Magento installation
  2. Use the following queries to filter categories by parent_id (change the ID's to the actual values for your setup)
{
  categories(filters: {parent_id: {eq: "2"}}) {
    items {
      name
    }
  }
}
{
  categories(filters: {parent_id: {in: ["2", "3"]}}) {
    items {
      name
    }
  }
}

@m2-assistant
Copy link

m2-assistant bot commented Oct 23, 2020

Hi @rogyar. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@rogyar rogyar force-pushed the graphql-add-parent-category-filter branch from 75f9f4f to 02f4e8c Compare October 23, 2020 17:05
@rogyar
Copy link
Contributor Author

rogyar commented Oct 23, 2020

@magento run WebAPI Tests

@keharper
Copy link
Contributor

@rogyar Will you/Atwix be updating the documentation, or should I do it?

@ghost ghost assigned sivaschenko Oct 23, 2020
@sivaschenko sivaschenko added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 23, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8373 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Oct 24, 2020
@rogyar
Copy link
Contributor Author

rogyar commented Oct 24, 2020

@andrewbess would you cover the documentation, please?

@andrewbess
Copy link
Contributor

@rogyar
Thank you. I will do it ASAP

@cpartica
Copy link
Contributor

We also have to update architectural repo. I'l do it. @rogyar .. so parent id just works? no other code needed?

@cpartica
Copy link
Contributor

@magento run all tests

@rogyar
Copy link
Contributor Author

rogyar commented Nov 12, 2020

Hi @cpartica. Yep, parent_id works since it's in the collection. I've covered this part with a test.

@magento-engcom-team magento-engcom-team merged commit 676a06e into magento:2.4-develop Nov 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 13, 2020

Hi @rogyar, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: CatalogGraphQl Event: MageCONF CD 2020 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Project: GraphQL Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GraphQL] Add parent_id to filters for subcategory pagination
7 participants