-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[GraphQL] Add possibility to filter categories by parent_id #30630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphQL] Add possibility to filter categories by parent_id #30630
Conversation
Hi @rogyar. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Added test coverage
75f9f4f
to
02f4e8c
Compare
@magento run WebAPI Tests |
@rogyar Will you/Atwix be updating the documentation, or should I do it? |
Hi @sivaschenko, thank you for the review.
|
@andrewbess would you cover the documentation, please? |
@rogyar |
We also have to update architectural repo. I'l do it. @rogyar .. so parent id just works? no other code needed? |
@magento run all tests |
Hi @cpartica. Yep, |
Hi @rogyar, thank you for your contribution! |
Description (*)
This PR introduces a possibility to filter the result set of categories by
parent_id
Fixed Issues (if relevant)
Manual testing scenarios (*)
parent_id
(change the ID's to the actual values for your setup)