Skip to content

Add path verification to Mediagallery uploader plugin #30662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 27, 2020
Merged

Add path verification to Mediagallery uploader plugin #30662

merged 3 commits into from
Nov 27, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Oct 27, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Cannot Import Products when Enable Old Media Gallery is set to No #30649

Manual testing scenarios (*)

  1. Set Enable Old Media Gallery to "NO" in STORES > CONFIGURATION > SYSTEM > ADVANCED

  2. Go to System > Import

  3. Import valid CSV of products (no images defined)

Products to be validated and imported successfully

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 27, 2020

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@Nazar65
Copy link
Member Author

Nazar65 commented Oct 27, 2020

@magento run all tests

sivaschenko
sivaschenko requested changes Oct 27, 2020
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @Nazar65 ! Can you please add an integration test covering the \Magento\Framework\File\Uploader::save with media and non-media destionation

@ghost ghost assigned sivaschenko Oct 27, 2020
@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: pending review Severity: S1 Affects critical data or functionality and forces users to employ a workaround. and removed Progress: needs update labels Oct 27, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Nov 2, 2020

I'm still working on test coverage :)

@engcom-Charlie
Copy link
Contributor

@Nazar65 I will take care of test coverage.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@sidolov sidolov added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Nov 16, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8467 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Nov 17, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Set Enable Old Media Gallery to "NO" in STORES > CONFIGURATION > SYSTEM > ADVANCED
  2. Go to System > Import
  3. Import valid CSV of products (no images defined)

Before: ✖️ Validation fails - exception "The file cannot be uploaded".

Screenshot from 2020-11-17 11-16-52

After: ✔️ Products were validated and imported successfully

Screenshot from 2020-11-17 11-21-38
Screenshot from 2020-11-17 12-16-17

Note: @Nazar65 @sivaschenko @sidolov We have errors in the exception.log file when importing products with images.
But these errors are not caused by changes from this PR.

Screenshot from 2020-11-17 12-11-38

@engcom-Alfa engcom-Alfa added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Nov 17, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Nov 17, 2020
@sivaschenko
Copy link
Member

@engcom-Alfa can you please open an issue describing the discovered exception

@engcom-Alfa
Copy link
Contributor

@sivaschenko The issue with the description of the detected exception has been created - #30978

@magento-engcom-team magento-engcom-team mentioned this pull request Nov 27, 2020
Closed
1 task
magento-engcom-team pushed a commit that referenced this pull request Nov 27, 2020
@gabrieldagama
ENGCOM-8467: Add path verification to Mediagallery uploader plugin #3…
9517d70 
…0662
@magento-engcom-team magento-engcom-team merged commit d1dd9c2 into magento:2.4-develop Nov 27, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 27, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

@sivaschenko sivaschenko Awaiting requested review from sivaschenko

Assignees

@sivaschenko sivaschenko

@sidolov sidolov

@engcom-Alfa engcom-Alfa

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: MediaGalleryIntegration Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot Import Products when Enable Old Media Gallery is set to No
6 participants
@Nazar65 @engcom-Charlie @magento-engcom-team @engcom-Alfa @sivaschenko @sidolov