MC-23904: Can't Refund Invoice Without 0 Quantities Through REST API

[engcom-Echo]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Can't Refund Invoice Without 0 Quantities Through REST API #23069

Manual testing scenarios (*)

1. See: Can't Refund Invoice Without 0 Quantities Through REST API #23069

Additional Information:
Endpoint: POST V1/invoice/:invoiceId/refund
If you try to apply the service to an invoice created using an offline payment method, the system will return a validation error.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Echo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[engcom-Echo]

@magento run all tests

[ihor-sviziev]

I believe right now you can't even do a refund in the admin, not only through the web api, or maybe that's another use case? ❓

[gabrieldagama]

@magento run all tests

[engcom-Echo]

@magento run all tests

[ihor-sviziev]

Hi @engcom-Echo ,
Could you explain use case when such request could be valid? I believe creating an order and doing credit memo from the admin with screenshots will be good enough

[engcom-Echo]

@ihor-sviziev. Thank you for your question. It is important.

Example refund with offline payment :

Example refund with online payment (PayPal):

Order:

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8421 has been created to process this Pull Request

[engcom-Oscar]

✔️ QA Passed

Manual testing scenario

1.Create an order with online payment method, like PayPal Express Checkout and with $0 shipping cost, ex. free shipping.
2.Invoice the order in admin
3.Try to refund the invoice using the 'POST' restAPI call "invoice/{invoiceId}/refund" - items at quantity 0 and a positive adjustment. For example:
{"items": [{"qty": 0, "orderItemId": 2, "extensionAttributes": {}}], "appendComment": false, "notify": true, "isOnline": true, "arguments": {"adjustment_negative": 0.0, "adjustment_positive": 0.99, "shipping_amount": 0}}

Before applying changes provided in the PR, the API responds with error "We can't create a creditmemo without products." from the QuantityValidator.

Afters switching to the PR, refund work properly

[zakdma]

@magento import pull request to https://github.com/magento-tsg/magento2ce

[magento-engcom-team]

@zakdma the pull request successfully imported.

[m2-assistant]

Hi @engcom-Echo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.