Skip to content

Region field visible for Country when "Allow to Choose State if It is Optional for Country" is disabled #30763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

engcom-Kilo
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Region field visible for Country when "Allow to Choose State if It is Optional for Country" is disabled #30747

Manual testing scenarios (*)

  1. see Region field visible for Country when "Allow to Choose State if It is Optional for Country" is disabled #30747

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@engcom-Kilo engcom-Kilo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 3, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 3, 2020

Hi @engcom-Kilo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

…e if It is Optional for Country" is disabled.
@engcom-Kilo
Copy link
Contributor Author

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @gabrieldagama, thank you for the review.
ENGCOM-8428 has been created to process this Pull Request
✳️ @gabrieldagama, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@gabrieldagama gabrieldagama added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Nov 5, 2020
@engcom-Bravo engcom-Bravo self-assigned this Nov 5, 2020
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Manual testing scenario

  1. In General Settings set country that doesn't support States for Default Country and Allowed countries settings (eg. Czech Republic)
    Default and allow
  2. Make sure that your Default Country isn't selected in State is Required for field
    state as required
  3. In General Settings set Allow to Choose State if It is Optional for Country to NO
    Allow to choose
  4. Navigate to storefront as a guest and add product to cart.
  5. Go to Checkout page.

Before applying changes provided in this PR
Default Country is automatically selected in shipping address form but region input field is visible.
Store

After switching to the PR
Default Country is automatically selected in shipping address form and region field is hidden.
Region

@engcom-Bravo engcom-Bravo added Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope labels Nov 5, 2020
@engcom-Kilo
Copy link
Contributor Author

@magento-engcom-team
Copy link
Contributor

@engcom-Kilo the pull request successfully imported.

@magento-engcom-team magento-engcom-team merged commit 6f9028e into magento:2.4-develop Nov 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 9, 2020

Hi @engcom-Kilo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Ui Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Region field visible for Country when "Allow to Choose State if It is Optional for Country" is disabled
5 participants