Skip to content

[MFTF] Refactoring of CaptchaWithDisabledGuestCheckoutTest #30803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 24, 2021
Merged

[MFTF] Refactoring of CaptchaWithDisabledGuestCheckoutTest #30803

merged 12 commits into from
Oct 24, 2021

Conversation

AnnaAPak
Copy link
Contributor

@AnnaAPak AnnaAPak commented Nov 5, 2020 •
edited by m2-assistant bot
Loading

Description (*)

The test is refactored according to the best practices followed by MFTF.

Manual testing scenarios (*)

Preconditions:

Guest checkout is disabled, 1 failed login attempt is allowed

  1. Add a product to the Cart
  2. Go to the MiniCart -> click the "Checkout" button
  3. Provide incorrect credentials on the Sign In popup
  4. Check if Captcha is displayed
  5. Reload page
  6. Go to the MiniCart -> click the "Checkout" button
  7. Check if Captcha is displayed

Resolved issues:

  1. resolves [Issue] WIP: [MFTF] Refactoring of CaptchaWithDisabledGuestCheckoutTest #30828: WIP: [MFTF] Refactoring of CaptchaWithDisabledGuestCheckoutTest

@m2-assistant
Copy link

m2-assistant bot commented Nov 5, 2020

Hi @AnnaAPak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Captcha Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 5, 2020
@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Nov 6, 2020
@sidolov
Copy link
Contributor

sidolov commented Nov 6, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Nov 6, 2020
Closed
@AnnaAPak AnnaAPak changed the title WIP: [MFTF] Refactoring of CaptchaWithDisabledGuestCheckoutTest [MFTF] Refactoring of CaptchaWithDisabledGuestCheckoutTest Nov 9, 2020
@AnnaAPak
Copy link
Contributor Author

AnnaAPak commented Nov 9, 2020

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@AnnaAPak
Copy link
Contributor Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@rogyar rogyar self-assigned this Dec 15, 2020
@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 15, 2020
@engcom-Delta
Copy link
Contributor

Note: QA not applicable

@engcom-Delta
Copy link
Contributor

Note: Some tests are waiting for status

@eduard13 eduard13 added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P3 May be fixed according to the position in the backlog. labels Aug 12, 2021
@eduard13
Copy link
Contributor

Hi @AnnaAPak, please fix the conflicting files and trigger all the builds.
Thank you.

@eduard13 eduard13 self-assigned this Aug 12, 2021
@AnnaAPak
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie engcom-Charlie self-assigned this Aug 25, 2021
@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Aug 25, 2021 •
edited
Loading

✔️ QA Passed

The provided MFTF test case is working fine and green in build. Please find the Allure report for the same.

image

image

@m2-community-project m2-community-project bot added Priority: P3 May be fixed according to the position in the backlog. Progress: accept and removed Progress: testing in progress labels Aug 25, 2021
@AnnaAPak
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sidolov
Copy link
Contributor

sidolov commented Oct 14, 2021

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team pushed a commit that referenced this pull request Oct 24, 2021
@sidolov
ENGCOM-8543: [MFTF] Refactoring of CaptchaWithDisabledGuestCheckoutTest
35b4cf5 
#30803
@magento-engcom-team magento-engcom-team merged commit 9fa231d into magento:2.4-develop Oct 24, 2021
@m2-assistant
Copy link

m2-assistant bot commented Oct 24, 2021

Hi @AnnaAPak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@eduard13 eduard13

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Captcha Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] WIP: [MFTF] Refactoring of CaptchaWithDisabledGuestCheckoutTest
7 participants
@AnnaAPak @sidolov @magento-engcom-team @engcom-Delta @eduard13 @engcom-Charlie @rogyar