MC-38105: Unable to set native session handler that is different from the one define in php.ini #30866

engcom-Echo · 2020-11-10T14:02:51Z

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes Unable to set native session handler that is different from the one define in php.ini after update to Magento 2.3 #24717

Manual testing scenarios (*)

See: #24717

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

… the one define in php.ini

m2-assistant · 2020-11-10T14:02:53Z

Hi @engcom-Echo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

engcom-Echo · 2020-11-10T14:07:30Z

@magento run all tests

engcom-Echo · 2020-11-11T10:16:57Z

@magento run all tests

ihor-sviziev · 2020-11-11T12:24:25Z

@magento run WebAPI Tests

ihor-sviziev

For now the only one improvement is needed.

Also tests were failing, let's check results again after restart

ihor-sviziev · 2020-11-11T12:21:15Z

dev/tests/integration/testsuite/Magento/Framework/Session/SessionManagerTest.php

            $this->assertEquals('private_no_expire', $sessionConfig->getOption('session.cache_limiter'));
            $this->assertEquals('explicit_save_path', $sessionConfig->getOption('session.save_path'));
            $this->assertArrayHasKey('session.use_only_cookies', self::$isIniSetInvoked);
            $this->assertEquals('1', self::$isIniSetInvoked['session.use_only_cookies']);
            foreach ($sessionConfig->getOptions() as $option => $value) {
-                if ($option=='session.save_handler') {
-                    $this->assertArrayNotHasKey('session.save_handler', self::$isIniSetInvoked);
+                if ($option == 'session.save_handler' && $value == 'user') {


Suggested change

if ($option == 'session.save_handler' && $value == 'user') {

if ($option === 'session.save_handler' && $value === 'user') {

engcom-Echo · 2020-11-11T12:35:36Z

For now the only one improvement is needed.

Also tests were failing, let's check results again after restart

Thanks. I think that the failure of the tests will be repeated and we need to change the solution.

ihor-sviziev · 2020-11-11T12:50:49Z

@engcom-Echo pls just merge latest changes from 2.4-develop. I believe these failures related to recent changes

… the one define in php.ini

engcom-Echo · 2020-11-13T10:44:26Z

@magento run all tests

magento-engcom-team · 2020-11-13T14:39:44Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8460 has been created to process this Pull Request

engcom-Kilo · 2020-11-17T12:09:41Z

@magento import pull request to https://github.com/magento-tsg/magento2ce

magento-engcom-team · 2020-11-17T12:12:34Z

@engcom-Kilo the pull request successfully imported.

engcom-Oscar · 2020-11-18T10:45:49Z

✔️ QA passed
Was checked case from Manual testing scenarios
❌ Before:
main.CRITICAL: Warning: SessionHandler::read(): open(127.0.0.1:11211/sess_0imeeaqmnvemdg4e3h57tat0ik, O_RDWR) failed: No such file or directory (2) in../vendor/magento/framework/Session/SaveHandler/Native.php on line 22 {"exception":"[object] (Exception(code: 0): Warning: SessionHandler::read(): open(127.0.0.1:11211/sess_0imeeaqmnvemdg4e3h57tat0ik, O_RDWR) failed: No such file or directory (2) in ../vendor/magento/framework/Session/SaveHandler/Native.php on line 22 at ../vendor/magento/framework/App/ErrorHandler.php:61)"} []
✔️ After:
No errors on homepage and in Admin on backend

m2-assistant · 2020-11-20T18:05:47Z

Hi @engcom-Echo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

MC-38105: Unable to set native session handler that is different from…

9fb7eb2

… the one define in php.ini

magento-engcom-team added Component: Session Release Line: 2.4 labels Nov 10, 2020

m2-community-project bot added Progress: pending review labels Nov 10, 2020

engcom-Echo requested review from engcom-Kilo, viktorpetryk and zakdma November 10, 2020 14:03

engcom-Echo added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Nov 10, 2020

Merge branch '2.4-develop' into MC-38105

e845a96

ihor-sviziev self-assigned this Nov 11, 2020

m2-community-project bot added Progress: review and removed Progress: pending review labels Nov 11, 2020

ihor-sviziev added Award: bug fix Auto-Tests: Covered All changes in Pull Request is covered by auto-tests labels Nov 11, 2020

ihor-sviziev requested changes Nov 11, 2020

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Nov 11, 2020

engcom-Echo and others added 2 commits November 12, 2020 14:00

MC-38105: Unable to set native session handler that is different from…

667e1dc

… the one define in php.ini

Merge branch '2.4-develop' into MC-38105

776515a

engcom-Echo force-pushed the MC-38105 branch 2 times, most recently from a5596aa to 6ede3eb Compare November 12, 2020 15:17

MC-38105: Unable to set native session handler that is different from…

caefb4e

… the one define in php.ini

engcom-Echo force-pushed the MC-38105 branch from 6ede3eb to caefb4e Compare November 13, 2020 10:44

ihor-sviziev approved these changes Nov 13, 2020

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Nov 13, 2020

viktorpetryk approved these changes Nov 16, 2020

View reviewed changes

m2-community-project bot assigned viktorpetryk Nov 16, 2020

engcom-Kilo approved these changes Nov 17, 2020

View reviewed changes

m2-community-project bot assigned engcom-Kilo Nov 17, 2020

m2-community-project bot added Progress: testing in progress and removed Progress: ready for testing labels Nov 18, 2020

engcom-Oscar self-assigned this Nov 18, 2020

m2-community-project bot added Progress: ready for testing and removed Progress: testing in progress labels Nov 18, 2020

m2-community-project bot added Progress: extended testing Progress: accept and removed Progress: ready for testing Progress: extended testing labels Nov 18, 2020

magento-engcom-team merged commit 3d9bcd6 into magento:2.4-develop Nov 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

MC-38105: Unable to set native session handler that is different from the one define in php.ini #30866

MC-38105: Unable to set native session handler that is different from the one define in php.ini #30866

Uh oh!

engcom-Echo commented Nov 10, 2020

Uh oh!

m2-assistant bot commented Nov 10, 2020

Uh oh!

engcom-Echo commented Nov 10, 2020

Uh oh!

engcom-Echo commented Nov 11, 2020

Uh oh!

ihor-sviziev commented Nov 11, 2020

Uh oh!

ihor-sviziev left a comment •

edited

Loading

Uh oh!

ihor-sviziev Nov 11, 2020

Uh oh!

engcom-Echo commented Nov 11, 2020

Uh oh!

ihor-sviziev commented Nov 11, 2020

Uh oh!

engcom-Echo commented Nov 13, 2020

Uh oh!

magento-engcom-team commented Nov 13, 2020

Uh oh!

engcom-Kilo commented Nov 17, 2020

Uh oh!

magento-engcom-team commented Nov 17, 2020

Uh oh!

engcom-Oscar commented Nov 18, 2020

Uh oh!

m2-assistant bot commented Nov 20, 2020

Uh oh!

Uh oh!

	if ($option == 'session.save_handler' && $value == 'user') {
	if ($option === 'session.save_handler' && $value === 'user') {

MC-38105: Unable to set native session handler that is different from the one define in php.ini #30866

MC-38105: Unable to set native session handler that is different from the one define in php.ini #30866

Uh oh!

Conversation

engcom-Echo commented Nov 10, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Nov 10, 2020

Uh oh!

engcom-Echo commented Nov 10, 2020

Uh oh!

engcom-Echo commented Nov 11, 2020

Uh oh!

ihor-sviziev commented Nov 11, 2020

Uh oh!

ihor-sviziev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev Nov 11, 2020

Choose a reason for hiding this comment

Uh oh!

engcom-Echo commented Nov 11, 2020

Uh oh!

ihor-sviziev commented Nov 11, 2020

Uh oh!

engcom-Echo commented Nov 13, 2020

Uh oh!

magento-engcom-team commented Nov 13, 2020

Uh oh!

engcom-Kilo commented Nov 17, 2020

Uh oh!

magento-engcom-team commented Nov 17, 2020

Uh oh!

engcom-Oscar commented Nov 18, 2020

Uh oh!

m2-assistant bot commented Nov 20, 2020

Uh oh!

Uh oh!

ihor-sviziev left a comment •

edited

Loading