#30218 GraphQL returns null address if optional telephone is set as e…

[SaftaArtem]

Description (*)

I change input and output type for telephone field. From String! to String, because telephone field has 3 states(no, required, optional)

Fixed Issues (if relevant)

1. Fixes GraphQL returns null address if optional telephone is set as empty string #30218

Manual testing scenarios (*)

Stores - Configuration - Customer - Customer Configuration - Name and Address Options
Set Show Telephone to

1. No
2. Optional
3. Required

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @SaftaArtem. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[rogyar]

Hi @SaftaArtem. Good job, thank you for your collaboration. According to the definition of done all the changes should be covered by auto-tests. I would ask you to cover this case with an API-funcitonal test. The test will create cart address with no telephone provided and assert that there's no error in return.

Thank you

[SaftaArtem]

Hi, *@rogyar, i wrote tests for creating and getting new address without telephone field* чт, 19 нояб. 2020 г. в 17:29, Yaroslav Rogoza <[email protected]>:

…

***@***.**** requested changes on this pull request. Hi @SaftaArtem <https://github.com/SaftaArtem>. Good job, thank you for your collaboration. According to the definition of done <https://devdocs.magento.com/guides/v2.3/contributor-guide/contributing_dod.html> all the changes should be covered by auto-tests. I would ask you to cover this case with an API-funcitonal test. The test will create cart address with no telephone provided and assert that there's no error in return. Thank you — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30982 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE5YSDK22TBS6NFZNKA6DOTSQU2WHANCNFSM4T3HEE3Q> .

[rogyar]

@magento run WebAPI Tests

[rogyar]

Hi @SaftaArtem. Good job. In the meantime, could I ask you to sign Adobe CLA. Without your sign, we cannot proceed with processing the PR.

Thank you.

[SaftaArtem]

Done. пн, 23 нояб. 2020 г. в 14:19, Yaroslav Rogoza <[email protected]>:

…

Hi @SaftaArtem <https://github.com/SaftaArtem>. Good job. In the meantime, could I ask you to sign Adobe CLA <http://opensource.adobe.com/cla.html>. Without your sign, we cannot proceed with processing the PR. Thank you. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30982 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE5YSDO4BNE6WA4FNORCWWLSRJHL5ANCNFSM4T3HEE3Q> .

[rogyar]

Hi @SaftaArtem. Please, take a look at the failing test.

Thank you.

[m2-assistant]

Hi @SaftaArtem, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.