Skip to content

Wrong date show in datepicker after saving a cart price rule, product special price date on administrator Dutch locale. #31047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

engcom-Kilo
Copy link
Contributor

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Wrong date show in datepicker after saving a cart price rule, product special price date on administrator Dutch locale  #30382

Manual testing scenarios (*)

  1. see Wrong date show in datepicker after saving a cart price rule, product special price date on administrator Dutch locale  #30382

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 25, 2020

Hi @engcom-Kilo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 25, 2020
…e, product special price date on administrator Dutch locale.
@engcom-Kilo
Copy link
Contributor Author

@magento run all tests

@engcom-Kilo
Copy link
Contributor Author

@magento-engcom-team
Copy link
Contributor

@engcom-Kilo the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-31047.

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Manual testing scenario

  1. Go to Admin Account Settings
  2. Set Interface Locale - Nederlands (Nederland) / Nederlands (Nederland) and **Save Account
  3. Go to Marketing - Cart Price Rule and click Add New Rule
  4. Fille in all the required fields
  5. Set values:
  • From - 28-05-2020
  • To - 31-12-2020
    28_08_12_set
  1. Save rule
  2. Go to Cart Price Rules grid and select the previously created rule
  3. Check the From and To dates

BEFORE applying changes provided in this PR, the date has changed to:

  • From - 20-05-2028
  • To - 20-12-2031
    28_08_12

AFTER switching to the PR, the From and To dates are not changed on editing
after

Tested a Cart Price rule with previously set dates.
The Discount is applied successfully 👍
simple_order

@zakdma
Copy link
Contributor

zakdma commented Dec 1, 2020

@magento-engcom-team
Copy link
Contributor

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-31047.

@magento-engcom-team magento-engcom-team merged commit b89fc2f into magento:2.4-develop Dec 2, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 2, 2020

Hi @engcom-Kilo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Ui Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: extended testing QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong date show in datepicker after saving a cart price rule, product special price date on administrator Dutch locale
5 participants