Skip to content

MC-37807: Link to a file of a Product with Customizable Option(File) is not available throughout a multishipping checkout process #31066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 12, 2020
Merged

MC-37807: Link to a file of a Product with Customizable Option(File) is not available throughout a multishipping checkout process #31066

merged 5 commits into from
Dec 12, 2020

Conversation

engcom-Echo
Copy link
Contributor

@engcom-Echo engcom-Echo commented Nov 26, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#

Manual testing scenarios (*)

Steps to Reproduce:

  1. Go to the Storefront as the created Customer
  2. Add the created Product to the Shopping Cart (Qty = 2), uploading a valid file
  3. Open the mini-cart
  4. Click the “View and Edit Cart” link
  5. Click the “Check Out with Multiple Addresses” link
  6. Select shipping addresses on the “Ship to Multiple Addresses”
  7. Click the “Go to Shipping Information” button
  8. Select Flat Rate - Fixed Shipping Method for the each address
  9. Click the “Continue to Billing Information” button
  10. Select “Check / Money order” Payment Method
  11. Click the “Go to Review Your Order” button

Expected results:
There should be a link, enabling file downloading, throughout entire multishipping checkout process (name of the file)

Actual results:
There is no link enabling file downloading throughout entire multishipping checkout process (name of the file)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] MC-37807: Link to a file of a Product with Customizable Option(File) is not available throughout a multishipping checkout process #31095: MC-37807: Link to a file of a Product with Customizable Option(File) is not available throughout a multishipping checkout process

@engcom-Echo
MC-37807: Link to a file of a Product with Customizable Option(File) …
f13958e 
…is not available throughout a multishipping checkout process
@m2-assistant
Copy link

m2-assistant bot commented Nov 26, 2020

Hi @engcom-Echo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@gabrieldagama gabrieldagama added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Nov 26, 2020
@engcom-Echo
MC-37807: Link to a file of a Product with Customizable Option(File) …
9bd13e4 
…is not available throughout a multishipping checkout process
@engcom-Echo
Copy link
Contributor Author

@magento run all tests

zakdma
zakdma suggested changes Nov 27, 2020
View reviewed changes
dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php Outdated
* @var \Magento\Multishipping\Block\Checkout\Overview
* @var Overview
*/
protected $block;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need this be protected? Make it private if possible

dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php Outdated
*/
protected $_block;
protected $objectManager;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need this be protected? Make it private if possible

dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php
/**
* @var Item
*/
private $item;

protected function setUp(): void
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add @inheritdoc annotation

dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php Outdated
['template' => 'cart/item/default.phtml']
);
$this->quote = $this->objectManager->get(Quote::class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ...Factory to create objects.
Same for next 2 lines

dev/tests/integration/testsuite/Magento/Multishipping/Block/Checkout/OverviewTest.php Outdated
/** @var $quote \Magento\Quote\Model\Quote */
$quote = $this->_objectManager->create(\Magento\Quote\Model\Quote::class);
$item->setQuote($quote);
$product = $this->product->load('1');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to use ProductRepository to get product instance by ID

@engcom-Echo
Copy link
Contributor Author

@magento run all tests

@engcom-Echo engcom-Echo requested a review from zakdma November 30, 2020 10:15
@engcom-Bravo engcom-Bravo self-assigned this Nov 30, 2020
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Manual testing scenario

  1. Create a Simple Product with Customizable Option type - File
    cust_opt_type_file
  2. Go to Storefront and Sign In as Customer
  3. Open the previously crated products page and Upload a valid file
    valid_file_upload
  4. Add the previously created product to the Cart in a Quantity of 2 items
  5. Click on mini cart and click View and Edit Cart
  6. Click Check Out with Multiple Addresses
  7. Select different addresses in Ship to Multiple Addresses window
    1_Ship to multiple
    Note that the link to the image files are valid
  8. Click Go to Shipping Information
  9. Observe the links to the file in Select Shipping Method
    2_sel_ship_meth
    Note that the link to the image files are valid
  10. Click Continue to Billing Information
  11. Click Go to Review Your Order
  12. Observe the links to the files in Review Order window
    3_place_order
    Note that the links are valid and redirect to downloading the previously uploaded image

BEFORE applying changes provided in this PR, only text with image name was displayed
before

AFTER switching to the PR, the text is a link that redirects to file downloading. The links are valid through the whole multi shipping process.
The order could be Placed successfully.

@engcom-Bravo
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Nov 30, 2020
Closed
@engcom-Bravo engcom-Bravo added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed Progress: testing in progress labels Nov 30, 2020
@zakdma
Copy link
Contributor

zakdma commented Dec 10, 2020

@magento import code to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@zakdma, an error occurred during the Pull Request import.

1 similar comment
@magento-engcom-team
Copy link
Contributor

@zakdma, an error occurred during the Pull Request import.

@zakdma
Copy link
Contributor

zakdma commented Dec 10, 2020

@magento import code to https://github.com/magento-tsg/magento2ce

@magento-engcom-team
Copy link
Contributor

@zakdma the branch with code successfully imported intomagento-tsg/magento2ce repository. Branch name: imported-magento-magento2-31066.

@magento-engcom-team magento-engcom-team merged commit fe3af97 into magento:2.4-develop Dec 12, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 12, 2020

Hi @engcom-Echo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Kilo engcom-Kilo engcom-Kilo approved these changes

@viktorpetryk viktorpetryk Awaiting requested review from viktorpetryk

@zakdma zakdma Awaiting requested review from zakdma

Assignees

@zakdma zakdma

@engcom-Bravo engcom-Bravo

@engcom-Kilo engcom-Kilo

Labels
Area: Frontend Component: Multishipping Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] MC-37807: Link to a file of a Product with Customizable Option(File) is not available throughout a multishipping checkout process
6 participants
@engcom-Echo @engcom-Bravo @zakdma @magento-engcom-team @engcom-Kilo @gabrieldagama