Skip to content

MFTF: Admin Login As Customer - Change Account Information Test #31100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 24, 2021
Merged

MFTF: Admin Login As Customer - Change Account Information Test #31100

merged 5 commits into from
Oct 24, 2021

Conversation

DmitryTsymbal
Copy link
Contributor

This PR contains a test for changing customer Information using Login As Customer functionality

Steps to reproduce:

1 - Create a customer

2 - Login to customer's account using Login As Customer functionality

3 - Update Customer's information

4 - Perform assertions

@m2-assistant
Copy link

m2-assistant bot commented Nov 30, 2020

Hi @DmitryTsymbal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Customer Component: LoginAsCustomer Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 30, 2020
@DmitryTsymbal
Copy link
Contributor Author

@magento run all tests

@dmytro-ch dmytro-ch self-assigned this Nov 30, 2020
@dmytro-ch dmytro-ch added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Nov 30, 2020
@DmitryTsymbal
Copy link
Contributor Author

@magento run all tests

@dmytro-ch
Copy link
Contributor

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@dmytro-ch
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE

@dmytro-ch
Copy link
Contributor

@magento run Functional Tests EE

1 similar comment
@dmytro-ch
Copy link
Contributor

@magento run Functional Tests EE

@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Apr 26, 2021
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-9033 has been created to process this Pull Request

@eduard13 eduard13 added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P3 May be fixed according to the position in the backlog. labels Aug 18, 2021
@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-9033 has been created to process this Pull Request

@eduard13
Copy link
Contributor

@magento create issue

@engcom-Charlie engcom-Charlie self-assigned this Aug 18, 2021
@engcom-Charlie
Copy link
Contributor

Hi @DmitryTsymbal

Thanks for the contribution!

While setting up your branch on local for testing, we are getting below errors:

image

We have followed below steps:
1. Git clone via git clone https://github.com/DmitryTsymbal/magento2.git command.
2. Git checkout in-branch via git checkout AdminLoginAsCustomerChangeAccountInformation command.
3. Running composer install. And then we are getting above error.

Can you please help us on this.

Thank you in advance!

Merge branch '2.4-develop' of https://github.com/magento/magento2 int…
cfbeace 
…o AdminLoginAsCustomerChangeAccountInformation

Updating Working Branch with 2.4-develop
@DmitryTsymbal
Copy link
Contributor Author

Hello @engcom-Charlie
Thank you for the update. I have been merged 2.4-develop into working branch and was able run "composer install" command successfully without any issues.
Please check.
Thanks!

@DmitryTsymbal
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Charlie
Copy link
Contributor

Hi @DmitryTsymbal,

Thanks for the update. Will look into it!

@engcom-Charlie
Copy link
Contributor

Hi @DmitryTsymbal,

The setup is working fine now. I am able to do composer install in PR branch. Moving the issue to Ready for Testing.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sidolov
Copy link
Contributor

sidolov commented Oct 14, 2021

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-engcom-team pushed a commit that referenced this pull request Oct 24, 2021
@sidolov
ENGCOM-9033: MFTF: Admin Login As Customer - Change Account Informati…
c189186 
…on Test #31100
@magento-engcom-team magento-engcom-team merged commit 32f9377 into magento:2.4-develop Oct 24, 2021
@m2-assistant
Copy link

m2-assistant bot commented Oct 24, 2021

Hi @DmitryTsymbal, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@eduard13 eduard13 eduard13 approved these changes

Assignees

@dmytro-ch dmytro-ch

@eduard13 eduard13

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Customer Component: LoginAsCustomer Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DmitryTsymbal @dmytro-ch @magento-engcom-team @eduard13 @engcom-Charlie @sidolov