501 mftf fails to rerun when storefront customer log out occurs after customer deletion #31101

sagar1dahiwala · 2020-11-30T15:47:03Z

Description (*)

Updated MFTF Tests that fails to Rerun When Test Logs Out of Storefront After Deleting Customer

Related Pull Requests

Fixed Issues (if relevant)

Fixes magento/partners-magento2b2b#501

Manual testing scenarios (*)

None

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

- Updating CE test when log out performed after customer is deleted

- Updating CE test when log out performed after customer is deleted - All the test are covered

m2-assistant · 2020-11-30T15:47:06Z

Hi @sagar1dahiwala. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

danmooney2 · 2020-11-30T16:13:13Z

@magento run Functional Tests CE

danmooney2 · 2020-11-30T18:55:26Z

...nto/Catalog/Test/Mftf/Test/StorefrontPurchaseProductCustomOptionsDifferentStoreViewsTest.xml

@@ -48,6 +48,8 @@
        </before>

        <after>
+            <!-- Customer Log Out -->
+            <actionGroup ref="StorefrontCustomerLogoutActionGroup" stepKey="customerLogout"/>


Please use the same stepkey: customerLogoutStorefront

danmooney2 · 2020-11-30T18:56:18Z

...gento/Swatches/Test/Mftf/Test/StorefrontCustomerCanChangeProductOptionsUsingSwatchesTest.xml

@@ -22,8 +22,9 @@
            <createData entity="Simple_US_Customer" after="createCategory" stepKey="createCustomer"/>
        </before>
        <after>
+            <!-- Logout customer -->
+            <actionGroup ref="StorefrontCustomerLogoutActionGroup" stepKey="customerLogoutStorefront"/>


Please use the same step key: logoutFromCustomer

- Few More test are corrected

…ar1dahiwala/magento2 into 501_mftf_fails_to_rerun_when_logsout

danmooney2 · 2020-12-01T14:13:43Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

danmooney2 · 2020-12-01T14:16:09Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

danmooney2 · 2020-12-01T14:45:39Z

@magento run Functional Tests CE, Functional Tests EE, Semantic Version Checker

… When Test Logs Out of Storefront After Deleting Customer - Fixing SVC failures

dhaecker · 2020-12-01T21:01:00Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Semantic Version Checker

dhaecker · 2020-12-02T16:49:57Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Semantic Version Checker

m2-assistant · 2020-12-10T03:39:54Z

Hi @sagar1dahiwala, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

sagar1dahiwala added 2 commits November 24, 2020 16:42

magento/partners-magento2b2b#501: mftf fails to rerun when logsout

7f362ab

- Updating CE test when log out performed after customer is deleted

magento/partners-magento2b2b#501: mftf fails to rerun when logout

6cf729f

- Updating CE test when log out performed after customer is deleted - All the test are covered

magento-engcom-team added Component: Backend Component: Catalog Component: CatalogRule Component: Checkout Component: LoginAsCustomer Component: Persistent Component: Shipping Component: Swatches Component: Wishlist Release Line: 2.4 labels Nov 30, 2020

Merge branch '2.4-develop' into 501_mftf_fails_to_rerun_when_logsout

9e2aa7c

danmooney2 self-assigned this Nov 30, 2020

m2-community-project bot added the Progress: review label Nov 30, 2020

danmooney2 marked this pull request as ready for review November 30, 2020 18:54

danmooney2 changed the title ~~501 mftf fails to rerun when logs out~~ 501 mftf fails to rerun when storefront customer log out occurs after customer deletion Nov 30, 2020

danmooney2 suggested changes Nov 30, 2020

View reviewed changes

m2-community-project bot added Progress: needs update and removed Progress: review labels Nov 30, 2020

sagar1dahiwala added 2 commits November 30, 2020 17:22

magento/partners-magento2b2b#501: mftf fails to rerun when logsout

fa781f9

- Few More test are corrected

Merge branch '501_mftf_fails_to_rerun_when_logsout' of github.com:sag…

c4a84d8

…ar1dahiwala/magento2 into 501_mftf_fails_to_rerun_when_logsout

m2-community-project bot added Progress: review and removed Progress: needs update labels Nov 30, 2020

danmooney2 approved these changes Dec 1, 2020

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: review labels Dec 1, 2020

m2-community-project bot added Progress: review Progress: ready for testing and removed Progress: ready for testing Progress: review labels Dec 1, 2020

Merge branch '2.4-develop' into 501_mftf_fails_to_rerun_when_logsout

a742ba3

magento/partners-magento2b2b#501: [Test Fix] MFTF Tests Fail to Rerun…

7e25908

… When Test Logs Out of Storefront After Deleting Customer - Fixing SVC failures

dhaecker approved these changes Dec 1, 2020

View reviewed changes

m2-community-project bot assigned dhaecker Dec 1, 2020

sidolov added the project: B2B label Dec 2, 2020

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels Dec 4, 2020

magento-engcom-team merged commit 89fc890 into magento:2.4-develop Dec 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

501 mftf fails to rerun when storefront customer log out occurs after customer deletion #31101

501 mftf fails to rerun when storefront customer log out occurs after customer deletion #31101

Uh oh!

sagar1dahiwala commented Nov 30, 2020 •

edited by danmooney2

Loading

Uh oh!

m2-assistant bot commented Nov 30, 2020

Uh oh!

danmooney2 commented Nov 30, 2020

Uh oh!

danmooney2 Nov 30, 2020

Uh oh!

sagar1dahiwala Nov 30, 2020

Uh oh!

danmooney2 Nov 30, 2020

Uh oh!

sagar1dahiwala Nov 30, 2020

Uh oh!

danmooney2 commented Dec 1, 2020

Uh oh!

danmooney2 commented Dec 1, 2020

Uh oh!

danmooney2 commented Dec 1, 2020

Uh oh!

dhaecker commented Dec 1, 2020

Uh oh!

dhaecker commented Dec 2, 2020

Uh oh!

m2-assistant bot commented Dec 10, 2020

Uh oh!

Uh oh!

501 mftf fails to rerun when storefront customer log out occurs after customer deletion #31101

501 mftf fails to rerun when storefront customer log out occurs after customer deletion #31101

Uh oh!

Conversation

sagar1dahiwala commented Nov 30, 2020 • edited by danmooney2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Nov 30, 2020

Uh oh!

danmooney2 commented Nov 30, 2020

Uh oh!

danmooney2 Nov 30, 2020

Choose a reason for hiding this comment

Uh oh!

sagar1dahiwala Nov 30, 2020

Choose a reason for hiding this comment

Uh oh!

danmooney2 Nov 30, 2020

Choose a reason for hiding this comment

Uh oh!

sagar1dahiwala Nov 30, 2020

Choose a reason for hiding this comment

Uh oh!

danmooney2 commented Dec 1, 2020

Uh oh!

danmooney2 commented Dec 1, 2020

Uh oh!

danmooney2 commented Dec 1, 2020

Uh oh!

dhaecker commented Dec 1, 2020

Uh oh!

dhaecker commented Dec 2, 2020

Uh oh!

m2-assistant bot commented Dec 10, 2020

Uh oh!

Uh oh!

sagar1dahiwala commented Nov 30, 2020 •

edited by danmooney2

Loading