Skip to content

Feature south america country regions #31158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 31, 2021
Merged

Feature south america country regions #31158

merged 5 commits into from
Jan 31, 2021

Conversation

nikolalardev
Copy link
Contributor

@nikolalardev nikolalardev commented Dec 4, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Add states/regions for Argentina, Bolivia, Chile, Ecuador, Guyana, Paraguay, Peru, Suriname and Venezuela.

Manual testing scenarios (*)

  1. Install Magento
  2. Check table directory_country_region for Argentina, Bolivia, Chile, Ecuador, Guyana, Paraguay, Peru, Suriname and Venezuela states/regions.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Feature south america country regions #31169: Feature south america country regions

@m2-assistant
Copy link

m2-assistant bot commented Dec 4, 2020

Hi @nikolalardev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@nikolalardev
Copy link
Contributor Author

@magento run all tests

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Dec 4, 2020
@sidolov
Copy link
Contributor

sidolov commented Dec 4, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Dec 4, 2020
Closed
4 tasks
@nikolalardev
Copy link
Contributor Author

@magento run all tests

@nikolalardev
Copy link
Contributor Author

@magento run WebAPI Tests

@nikolalardev
Copy link
Contributor Author

@magento run all tests

@nikolalardev
Copy link
Contributor Author

@magento run Functional Tests EE

@nikolalardev
Copy link
Contributor Author

@sidolov Hi can you merge it?

@nikolalardev
Copy link
Contributor Author

@magento run all tests

@gabrieldagama gabrieldagama added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P3 May be fixed according to the position in the backlog. labels Jan 21, 2021
@magento-engcom-team
Copy link
Contributor

Hi @gabrieldagama, thank you for the review.
ENGCOM-8685 has been created to process this Pull Request
✳️ @gabrieldagama, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Jan 22, 2021
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 22, 2021
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jan 22, 2021
@gabrieldagama gabrieldagama removed the Priority: P3 May be fixed according to the position in the backlog. label Jan 24, 2021
magento-engcom-team pushed a commit that referenced this pull request Jan 31, 2021
@gabrieldagama
ENGCOM-8685: Feature south america country regions #31158
1005ec9
@magento-engcom-team magento-engcom-team merged commit f3dfb04 into magento:2.4-develop Jan 31, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jan 31, 2021

Hi @nikolalardev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@kassner
Copy link
Contributor

kassner commented May 6, 2021 •
edited
Loading

@nikolalardev where did the list of regions came from? I am looking into Argentina and their short codes don't really say anything. There is some ISO definitions but they don't match either. Can you clarify?

For example, PayPal expects a different list, and then it only shows, for example, AR-N.

Thanks!

@nikolalardev
Copy link
Contributor Author

@kassner https://en.wikipedia.org/wiki/ISO_3166-2:AR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldagama gabrieldagama gabrieldagama approved these changes

Assignees

@gabrieldagama gabrieldagama

@engcom-Alfa engcom-Alfa

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Directory Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Feature south america country regions
6 participants
@nikolalardev @sidolov @magento-engcom-team @engcom-Alfa @kassner @gabrieldagama