-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Allow to load base64 encoded images and fonts #31162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to load base64 encoded images and fonts #31162
Conversation
Hi @vovayatsyuk. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento create issue |
@magento run all tests |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vovayatsyuk thanks for your contribution.
Can you please take a look at the failing \Magento\Csp\Model\Collector\ConfigCollectorTest
and fix it?
Thank you
Done. |
@magento run all tests |
@magento run all tests |
@magento run Integration Tests |
Hi @sidolov, thank you for the review. |
@magento give me 2.4-develop instance |
Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Alfa, here is your Magento Instance: https://354a2f4d539797723e2d5eade8412513-2-4-develop.instances.magento-community.engineering |
Hi @vovayatsyuk, thank you for your contribution! |
Description
Current Content Security Policy setup doesn't allow to load images and fonts via
data:
scheme which is quite a popular method to load local resources (base64 encoded images). Additionally, it's used internally by the browser cache (Chrome) when you refresh the page.Manual testing scenarios (*)

4. Apply the patch, and try again. No errors should appear in the log.Contribution checklist (*)
Resolved issues: