Adjust .editorconfig to correct the automatic formatting of db_schema_whitelist.json files

[DmitryFurs]

Description (*)

Since the .editorconfig file was changed to use two spaces for json files, this leads to problems with db_schema_whitelist.json files. All schemas are generated by the cli setup:db-declaration:generate-whitelist command and put json content formatted by the json_decode function with JSON_PRETTY_PRINT constant. This mechanism displays an indent of 4 spaces and does not add a new line at the bottom of the file. But when we change our file db_schema.xml and run setup:db-declaration:generate-whitelist cli command, it updates the contents of the db_schema_whitelist.json file, and when we opened it in the IDE, the .editorconfig add a new line at the bottom and we can't delete it, because it is always adding at the end on saving the file.

Related Pull Requests

#30062

Manual testing scenarios (*)

1. Open any db_schema_whitelist.json file in PhpStorm
2. And run Reformat Code
3. Press Ctrl+S to save file

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Adjust .editorconfig to correct the automatic formatting of db_schema_whitelist.json files #31171: Adjust .editorconfig to correct the automatic formatting of db_schema_whitelist.json files

[m2-assistant]

Hi @DmitryFurs. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8516 has been created to process this Pull Request

[magento-engcom-team]

@DmitryFurs thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[sidolov]

@magento create issue

[ihor-sviziev]

@magento run Static Tests

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

@magento run Database Compare, Functional Tests CE, Integration Tests

[engcom-Bravo]

✔️ QA Passed

Manual testing scenarios (*)

1. Open any db_schema_whitelist.json file in PhpStorm
2. And run Reformat Code
3. Press Ctrl+S to save file

BEFORE applying changes provided in the PR, the code has been refactored and a new line added at the end

AFTER switching to the PR, the code is not formatted. A "No lines changed, content is properly formated" message appears

"No lines changed, content is properly formated"

[engcom-Hotel]

@magento run Functional Tests CE, Integration Tests

[engcom-Hotel]

@magento run Functional Tests CE

[engcom-Bravo]

✔️ QA passed
The result is the same as in the report above #31166 (comment)

[m2-assistant]

Hi @DmitryFurs, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.