fix for ambigous column user_id in where clause

[dorupetruc]

Magento\Users\Model\ResourceModel\User\Collection addFilterToMap for user_id

Description (*)

When filtering Magento\Users\Model\ResourceModel\Users\Collection by user_id , it throws an SQL exception ( ambigous user_id in where condition )

Manual testing scenarios (*)

1. go to Backend > System > Permissions > All users grid
2. filter the grid by ID
3. expected result : grid filtered by ID
   actual result: first time it redirects to dashboard & subsequent access of All Users grid throws the aabove exception.

Resolved issues:

1. resolves [Issue] fix for ambigous column user_id in where clause #31216: fix for ambigous column user_id in where clause

[m2-assistant]

Hi @dorupetruc. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[sidolov]

@magento create issue

[danielrussob]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @danielrussob. Thank you for your request. I'm working on Magento instance for you.

[danielrussob]

@magento give me test instance

[magento-deployment-service]

Hi @danielrussob. Thank you for your request. I'm working on Magento instance for you.

[danielrussob]

@magento run all tests

[danielrussob]

Hello, @dorupetruc
thanks for your contribution! 💯

As: https://github.com/magento/magento2/pull/31205/checks?check_run_id=1517247098
Please sign "Adobe CLA Signed"

Tell me if you have some problems 👍

[magento-deployment-service]

Hi @danielrussob, here is your Magento Instance: https://41dfc9147a8cb9b305d1261c0f2eaf61.instances.magento-community.engineering
Admin access: https://41dfc9147a8cb9b305d1261c0f2eaf61.instances.magento-community.engineering/admin_e88b
Login: bb95098d
Password: 9c401add4064

[magento-deployment-service]

Hi @danielrussob, here is your Magento Instance: https://41dfc9147a8cb9b305d1261c0f2eaf61-2-4-develop.instances.magento-community.engineering
Admin access: https://41dfc9147a8cb9b305d1261c0f2eaf61-2-4-develop.instances.magento-community.engineering/admin_ad85
Login: bc562b95
Password: 8126cb38a8f5

[danielrussob]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @danielrussob. Thank you for your request. I'm working on Magento instance for you.

[danielrussob]

Hello @dorupetruc,
we (CC: @aleron75) are not able to reproduce the issue on vanilla Magento 2.4 Instance

Can you confirm that the only steps to reproduce the issue are the following:

go to Backend > System > Permissions > All users grid
filter the grid by ID
expected result: grid filtered by ID
actual result: the first time it redirects to dashboard & subsequent access of All Users grid throws the above exception.

Can you try with:

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @danielrussob. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @danielrussob, here is your Magento Instance: https://41dfc9147a8cb9b305d1261c0f2eaf61-2-4-develop.instances.magento-community.engineering
Admin access: https://41dfc9147a8cb9b305d1261c0f2eaf61-2-4-develop.instances.magento-community.engineering/admin_d6d2
Login: dd76a1da
Password: 96d07e7fd8e1

[magento-deployment-service]

Hi @danielrussob, here is your Magento Instance: https://41dfc9147a8cb9b305d1261c0f2eaf61-2-4-develop.instances.magento-community.engineering
Admin access: https://41dfc9147a8cb9b305d1261c0f2eaf61-2-4-develop.instances.magento-community.engineering/admin_a53a
Login: 49b4ca89
Password: 3f9a46b0f35c

[engcom-Alfa]

✔️ QA Passed

Case 1.

Manual testing scenario:

1. Add the code from the attached file
   Code_to_reproduce_31205.zip
2. Run in console: php bin/magento setup:upgrade;
3. Log in to the admin panel;
4. open URL /admin/column;

Before: ✖️ 2 exceptions occur

After: ✔️ No exceptions

Case 2.

Manual testing scenario:

1. Go to Admin -> System -> Permissions -> All users grid;
2. Filter the grid by ID;

After: ✔️ The grid filtered by ID correctly

[magento-engcom-team]

@dorupetruc thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[m2-assistant]

Hi @dorupetruc, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.