Skip to content

fix issue with logging each cookie as separate context #31259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix issue with logging each cookie as separate context #31259

wants to merge 1 commit into from

Conversation

aleksinoleg
Copy link
Contributor

Description (*)

When the number of cookies becomes more than 50 the warning log is written: "Unable to send the cookie. Maximum number of cookies would be exceeded." And each cookie is converting to a separate log context. And in the case of using the Graylog app, it is converting to a separate field.
By this pull request, the $_COOKIE array is converting to a string and writing as 'cookie' context while writing the log

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Exceed the number of cookies > 50
  2. Watch the log

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 11, 2020

Hi @aleksinoleg. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3 instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev ihor-sviziev self-assigned this Dec 11, 2020
@ihor-sviziev ihor-sviziev added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Dec 11, 2020
@ihor-sviziev
Copy link
Contributor

@aleksinoleg Finally, someone will fix that! 👍

We also were having this issue - we're sending logs to some Elasticsearch based tool, and it was hunting because of too many fields (each key is sent as a separate key). Also, it doesn't have any value for sending all cookies as separate values, so PR, in general, looks good to me.

Let's wait for the test results.
@magento run all tests

@aleksinoleg
Copy link
Contributor Author

@ihor-sviziev, I have no time to fix all stacked tests. It would be great if someone will fix it. Thanks

@ihor-sviziev
Copy link
Contributor

@sidolov @gabrieldagama could you provide info on why some tests are failing with no build results?

@ihor-sviziev
Copy link
Contributor

Hi @aleksinoleg,
Could you re-target your Pull Request to the 2.4-develop branch as the 2.3 release line is already closed for contributions?

@aleksinoleg aleksinoleg changed the base branch from 2.3 to 2.4-develop December 17, 2020 07:56
@aleksinoleg aleksinoleg changed the base branch from 2.4-develop to 2.3 December 17, 2020 07:57
@sidolov
Copy link
Contributor

sidolov commented Dec 17, 2020

@magento run all tests

@ihor-sviziev
Copy link
Contributor

Closing this PR as a duplicate of #31334

@m2-assistant
Copy link

m2-assistant bot commented Dec 18, 2020

Hi @aleksinoleg, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants