Fix issue with logging each cookie as separate context

[aleksinoleg]

Description (*)

When the number of cookies becomes more than 50 the warning log is written: "Unable to send the cookie. Maximum number of cookies would be exceeded." And each cookie is converting to a separate log context. And in the case of using the Graylog app, it is converting to a separate field.
By this pull request, the $_COOKIE array is converting to a string and writing as 'cookie' context while writing the log

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

1. Exceed the number of cookies > 50
2. Watch the log

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Fix issue with logging each cookie as separate context #31471: Fix issue with logging each cookie as separate context

[m2-assistant]

Hi @aleksinoleg. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[aleksinoleg]

This PR is #31259 variant for 2.4

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

Finally, someone will fix that! 👍

We also were having this issue - we're sending logs to some Elasticsearch based tool, and it was hunting because of too many fields (each key is sent as a separate key). Also, it doesn't have any value for sending all cookies as separate values, so PR, in general, looks good to me.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8557 has been created to process this Pull Request

[engcom-Bravo]

✔️ QA Passed

Manual testing scenario

1. Open web browser Firefox
2. Navigate to about:config
3. Find dom.storage.enabled option and change to false
4. Open Storefront in a new tab
5. Duplicate the tab, open the same page in another tab
6. Duplicate the tabs several times (3-4 new tabs)
7. Open debug.log file from ./var/log folder
8. Find the text "main.WARNING: Unable to send the cookie. Maximum number of cookies would be exceeded"

BEFORE switching to the PR

AFTER applying changes from the PR,

[engcom-Bravo]

@magento create issue

[m2-assistant]

Hi @aleksinoleg, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.